SubtitleDownloader (2 Viewers)

[Sypher]

Re: SubtitleDownloader 1.7

Thank you for the time & effort you put into this.

You were quite quick te respond. I wanted to change my reply to add this:

----
They've also moved the API to a subdomain. In order to make the transition seamless, they've added a redirect.
Querying the subdomain (api.bierdopje.com) directly will also be slightly faster, since you don't have to follow the redirect the old page gives you.

instead of bierdopje.com/api/KEY/etc. it becomes api.bierdopje.com/KEY/etc...
---

I couldn't find the "real" sourcecode for the SubtitleDownloader itself, so I couldn't verify how its really implemented. But if you did use the code mentioned in the zip file, it could use a few small adjustments

 

[seco]

Re: SubtitleDownloader 1.7

I edited my earlier post

Also, bierdopje.com seems to be hardcoded in Bierdopje.API source code, so we need a new .DLL of the API which has the api.bierdopje.com address. Unless I compile it by myself..

 

[Powdor]

Re: SubtitleDownloader 1.7

Hey Sypher and Seco,

Could it be that the bierdopje api evolved and got some better methods, I used some lib that was already on the net for a while...
If Mr. Seco could share his code I would be happy to look into it.. That code isn't that efficient, I know, but I wanted to get it up and running..

 

[Powdor]

Re: SubtitleDownloader 1.7

Seco,

Yes you are right the lib you use is old (relative). And has no knolidge of the new api.. I will look into that as well. As I mentioned before, I do not like the implementation of this lib. So I will probably rewrite it in the next couple of weeks..

 

[Sypher]

Re: SubtitleDownloader 1.7

Hey Sypher and Seco,

Could it be that the bierdopje api evolved and got some better methods, I used some lib that was already on the net for a while...
If Mr. Seco could share his code I would be happy to look into it.. That code isn't that efficient, I know, but I wanted to get it up and running..

Yes, after the API has been released at the end of Juli there have been minor changes and some new additions. The feature "GetAllSubsFor" has been added at 23 september 2009 in order to improve the reliability of the API.

Every call you save is a win. Even though they cache the requests for a small period of time, this is a better approach.
The API implementation that's on bierdopjeapi.googlecode.com isn't the official one (since there isn't any one (yet)), and apparently still uses the old URL and is missing the GetAllSubsFor-feature.

 

[seco]

Re: SubtitleDownloader 1.7

Ok guys, I'll wait for you to submit an optimized version of the Bierdopje downloader

 

[Gup]

Re: SubtitleDownloader 1.7

Seco,

I tried your downloader in combi with moving pictures. Is there a limit on the amount of downloaded subtitles? Because after progress of 30 titles the dll crashes......

 

[seco]

Re: SubtitleDownloader 1.7

Seco,

I tried your downloader in combi with moving pictures. Is there a limit on the amount of downloaded subtitles? Because after progress of 30 titles the dll crashes......

What you mean by crash? I presume you're using gibman's subtitle retriever patch? We should first narrow down the problem to the downloader (this thread) or retriever code (gibman's thread)

 

[Gup]

Re: SubtitleDownloader 1.7

I checked some more stuff. It's not related to a specific number. It has to do that both the downloader and the retriever don't have any failsaves build in. For instance moving pictures gives the imdb number for query but as format ttXXXXXX . This crashes your dll. Perhaps better build in some checks for correct format.

 

[seco]

Re: SubtitleDownloader 1.7

I checked some more stuff. It's not related to a specific number. It has to do that both the downloader and the retriever don't have any failsaves build in. For instance moving pictures gives the imdb number for query but as format ttXXXXXX . This crashes your dll. Perhaps better build in some checks for correct format.

From changelog 1.6:
- Added check to API that IMDB search queries use only numeric IMDB ID (not like "tt0375679")

-> Downloader doesn't crash, it throws exception. Gibman's patch for Moving Pictures has an error.

Line 1261 in the patch should be:

movieDetail.ImdbID = selectedMovie.ImdbID.Replace("tt", "");