SubtitleDownloader (2 Viewers)

seco

Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #71
    Re: SubtitleDownloader 1.0

    I think bierdopje is broken again. When I do a search query it only finds the english subtitle, even though there is indeed a dutch subtitle. Downloading the subtitle works fine.

    Are you using latest code from gibman? With TVSeries there was a bug where only english results were returned..
     

    scythe000

    Portal Pro
    July 6, 2008
    379
    15
    Re: SubtitleDownloader -project & My TVSeries

    Anybody? Should I post this somewhere else?

    What version of MP are you using? How is your subtitles configuration in MP? Are you using MPC integrated subtitles engine?

    Ok! Turns out someone had suggested I manually add DirectVobSub to the Vidoes Post Processing Tab. With that gone, I can now play videos without subs or with subs. Now, my only problem is that the subs are loading by default, and I'd like them not to load by default, but only by selecting through F9/i button. How do I do this?

    SAF latest, MP 1.0.2, StreamedMP
     

    Zinu

    Portal Pro
    February 28, 2008
    650
    23
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 1.0

    I think bierdopje is broken again. When I do a search query it only finds the english subtitle, even though there is indeed a dutch subtitle. Downloading the subtitle works fine.

    Are you using latest code from gibman? With TVSeries there was a bug where only english results were returned..

    I wasn't, any mytvseries is working now, thanks!

    I also have a request. Could you investigate the possibility of adding Ondertitels | Ondertitel.com | Nederlandse Ondertitels Downloaden Uploaden voor Video / Film / Divx / DVD to the list for Moving Pictures sources? It's a website where dutch subtitles for movies are often as first website uploaded.
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #74
    Re: SubtitleDownloader 1.0

    I wasn't, any mytvseries is working now, thanks!

    I also have a request. Could you investigate the possibility of adding Ondertitels | Ondertitel.com | Nederlandse Ondertitels Downloaden Uploaden voor Video / Film / Divx / DVD to the list for Moving Pictures sources? It's a website where dutch subtitles for movies are often as first website uploaded.

    I probably won't code anymore sources myself (well maybe moviesubtitles.org because it supports multiple languages) but everyone is free to implement ISubtitleDownloader interface which is found in SubtitleDownloader.dll.

    It could be possible that one makes ISubtitleDownloader implementation, like Ondertitels.dll and SubtitleDownloader could then load it dynamically from specific directory, but at the moment this is not possible and new implementations must be manually added to SubtitleDownloader.

    So, if you know C# or know someone that knows it you can make ISubtitleDownloader implementation and send the code for me.
     

    Zinu

    Portal Pro
    February 28, 2008
    650
    23
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 1.0

    Can I find the SubtitleDownloader source code somewhere for that? And the code for the other scrapers I can use as an example?
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #76
    Re: SubtitleDownloader 1.0

    Can I find the SubtitleDownloader source code somewhere for that? And the code for the other scrapers I can use as an example?

    I'll post some example to post #2 when I'll get my workstation back online (next week)

    EDIT: Bierdopje implementation that Powdor made: http://www.stepup.nl/bierdopjesubtitles.zip (BierdopjeSubtitles.cs)
     

    PashCracken

    Portal Member
    March 8, 2008
    15
    2
    Home Country
    Norway Norway
    Release Name search

    Hi Seco,

    Great work on this library :)

    I've started using it as part of my own subtitle downloader program. All is fine except for one thing that I feel are missing from SubtitleDownloader. Many sites like Subscene, Podnapisi, SubtitleSource, etc supports searching for release names. Looking at the code I can see that SubtitleDownloader does not support this. I think a new ReleaseNameSearchQuery type would be a great enhancement. From what I can see it should be fairly easy to implement.

    The reason I need this is that my subtitle downloader runs unattended on my homeserver and automatically downloads missing subtitles. Searching be release name gives me an easy way to automatically match the search results with what I'm looking for.

    I hope this is something that you would consider as an enhancement :)
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #79
    Re: Release Name search

    Hi Seco,

    Great work on this library :)

    I've started using it as part of my own subtitle downloader program. All is fine except for one thing that I feel are missing from SubtitleDownloader. Many sites like Subscene, Podnapisi, SubtitleSource, etc supports searching for release names. Looking at the code I can see that SubtitleDownloader does not support this. I think a new ReleaseNameSearchQuery type would be a great enhancement. From what I can see it should be fairly easy to implement.

    The reason I need this is that my subtitle downloader runs unattended on my homeserver and automatically downloads missing subtitles. Searching be release name gives me an easy way to automatically match the search results with what I'm looking for.

    I hope this is something that you would consider as an enhancement :)

    This is a good point. However, in my tests I never found a need for this kind of a query (but then again I wasn't going to make automatic matching).

    Can you give me some examples making a release search in Subscene, Podnapisi and Subtitlesource?
     

    PashCracken

    Portal Member
    March 8, 2008
    15
    2
    Home Country
    Norway Norway
    Re: Release Name search

    In Podnapisi a normal search for "24.s08e01.720p.hdtv.x264-immerse" gives 0 results. A release name search for the same gives very relevant matches. The only difference in the GET request is this:
    Normal:
    GET /ppodnapisi/search?tbsl=1&asdp=1&sK=24.s08e01.720p.hdtv.x264-immerse&sJ=0&submit=Search&sY=&sR= HTTP/1.1
    Release name:
    GET /ppodnapisi/search?tbsl=1&asdp=1&sK=&sJ=0&submit=Search&sY=&sR=24.s08e01.720p.hdtv.x264-immerse HTTP/1.1
    The only difference is filling in the sR parameter instead of the sK parameter.

    In Subscene a Film Name search for "24.s08e01.720p.hdtv.x264-immerse" will not give any relevant results. The release name search will also here be much better for exact matching.
    Title search:
    GET /filmsearch.aspx?q=24.s08e01.720p.hdtv.x264-immerse HTTP/1.1
    Release name search:
    GET /s.aspx?q=24.s08e01.720p.hdtv.x264-immerse HTTP/1.1

    In SubtitleSource I actually don't think there is any differences(default search searches for both title and release name) so no changes are needed there.

    So there are only minor differences in the requests, but the results are very different. In a general library like SubtitleDownloader I think it would be great to have a different SearchQuery for each type. That way you can also support those source that requires different requests for title and release name.
     

    Users who are viewing this thread

    Top Bottom