SubtitleDownloader (3 Viewers)

seco

Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #81
    Re: Release Name search

    In Podnapisi a normal search for "24.s08e01.720p.hdtv.x264-immerse" gives 0 results. A release name search for the same gives very relevant matches. The only difference in the GET request is this:
    Normal:
    GET /ppodnapisi/search?tbsl=1&asdp=1&sK=24.s08e01.720p.hdtv.x264-immerse&sJ=0&submit=Search&sY=&sR= HTTP/1.1
    Release name:
    GET /ppodnapisi/search?tbsl=1&asdp=1&sK=&sJ=0&submit=Search&sY=&sR=24.s08e01.720p.hdtv.x264-immerse HTTP/1.1
    The only difference is filling in the sR parameter instead of the sK parameter.

    In Subscene a Film Name search for "24.s08e01.720p.hdtv.x264-immerse" will not give any relevant results. The release name search will also here be much better for exact matching.
    Title search:
    GET /filmsearch.aspx?q=24.s08e01.720p.hdtv.x264-immerse HTTP/1.1
    Release name search:
    GET /s.aspx?q=24.s08e01.720p.hdtv.x264-immerse HTTP/1.1

    In SubtitleSource I actually don't think there is any differences(default search searches for both title and release name) so no changes are needed there.

    So there are only minor differences in the requests, but the results are very different. In a general library like SubtitleDownloader I think it would be great to have a different SearchQuery for each type. That way you can also support those source that requires different requests for title and release name.

    Ok, I see your point here.

    But the only problem seems to be the Podnapisi. Subscene already uses the "/s.apx" when searching with SearchQuery and SubtitleSource doesn't have any difference like you said.

    I wonder if changing Podnapisi parameter "sK" to "sR" be ok, it seems to give results with sR even if not searching with release name?
     

    PashCracken

    Portal Member
    March 8, 2008
    15
    2
    Home Country
    Norway Norway
    Re: Release Name search

    You are right. Changing the Podnapisi implementation to use the sR parameter might be all that is required. Looks like the sR searches also give good results for title searches.
    :)
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #83
    Re: Release Name search

    You are right. Changing the Podnapisi implementation to use the sR parameter might be all that is required. Looks like the sR searches also give good results for title searches.
    :)

    Yeah, at least that's easy for now. I'm bit reluctant adding new methods to the API.

    I'll post the new version soon, thanks for testing & feedback.
     

    Zinu

    Portal Pro
    February 28, 2008
    650
    23
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 1.0

    For some reason when using this with Moving Pictures the only result I get for dutch subtitle is 'ZEITGEIST-ORIENTATION-VIDEO.srt'. This is with every single movie entry. I don't know what it is and it's very strange, since it finds English subtitles fine. I don't know whether this is a SubtitleDownloader issue or a SubtitlesRetriever one... Maybe you understand anything of that? It's really strange... It's a totally random subtitle which I have no reference to anywhere, but it seems to find that in every single movie entry I try it with.

    And how about releasenames? If the scraper finds 7 results, all results are named for example CRASH.srt, but they are for different releases so for different syncs. This information to keep them apart is available op opensubtitles.org... why doesn't this show those releasenames but instead uses the same name every time?

    I'm talking about OpenSubtitles scraper.
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #85
    Re: SubtitleDownloader 1.0

    For some reason when using this with Moving Pictures the only result I get for dutch subtitle is 'ZEITGEIST-ORIENTATION-VIDEO.srt'. This is with every single movie entry. I don't know what it is and it's very strange, since it finds English subtitles fine. I don't know whether this is a SubtitleDownloader issue or a SubtitlesRetriever one... Maybe you understand anything of that? It's really strange... It's a totally random subtitle which I have no reference to anywhere, but it seems to find that in every single movie entry I try it with.

    And how about releasenames? If the scraper finds 7 results, all results are named for example CRASH.srt, but they are for different releases so for different syncs. This information to keep them apart is available op opensubtitles.org... why doesn't this show those releasenames but instead uses the same name every time?

    I'm talking about OpenSubtitles scraper.

    Please provide more information, settings that you are using, movie/episode information that you are fetching the subtitles for, screenshots of the search results etc.
     

    McFly

    MP Donator
  • Premium Supporter
  • November 5, 2008
    18
    1
    Milan
    Home Country
    Italy Italy
    Re: SubtitleDownloader 1.5

    Hello Seco, do you think is it possible to use RSS feeds to integrate the ::Italian Subs Addicted:: - La Community italiana dei Sottotitoli repository?
    They launched the MY ITASA service, a sort of personal subscription to the user favorite TV series, accessible via RSS.

    In fact there are two softwares that use RSS to directly download srt files from this site: jRss2sub and RSS2Sub LT (I know it's in italian language, but there's google translator ;) )
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #87
    Re: SubtitleDownloader 1.5

    ATTENTION: If using 1.5, create "SubtitleDownloaders" folder to the Mediaportal installation directory! (a bug which will be fixed in 1.6)
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #88
    Re: SubtitleDownloader 1.5

    I've added support for MovieSubtitles.org.

    This is probably the last site I'll add "official" support for. Every other sites that have not been included, everyone is free to implement ISubtitleDownloader interface and provide a compiled .dll :)
     

    Sypher

    Portal Member
    June 13, 2008
    26
    2
    Home Country
    Netherlands Netherlands
    Re: SubtitleDownloader 1.7

    I've sifted a bit (I'm not a C# coder) trough the sourcecode (the bierdopjesubtitles.zip you mentioned in your first post) and discovered that your implementation of the Bierdopje-api isn't very efficient.

    You request every episode for a specific show, and then you narrow it down to the one you want.

    Instead, you could (and I suggest you do that for certain reasons) try the "GetAllSubsFor" call.
    The show id parameter can both be the showid they use at the site or the TheTVDB ID.
    Please note that you should set the "istvdbid" to true if the ID given is the TheTVDB ID.

    So the call will be:
    GetAllSubsFor/73739/1/1/nl/true (the parameters: integer showid, integer season, integer episode, string language(nl/en), (optional: istvdbid true/false))

    If you want the subs for Lost S01E01.

    This way, you can do less calls, and the whole process should be working a bit faster and saves both server as client bandwidth. :)
     

    seco

    Retired Team Member
  • Premium Supporter
  • August 7, 2007
    1,575
    1,239
    Home Country
    Finland Finland
    • Thread starter
    • Moderator
    • #90
    Re: SubtitleDownloader 1.7

    Thanks for the input Sypher :)

    Bierdopje implementation was actually made by a forum member Powdor, many thanks for him for getting the Bierdopje support in the first place.

    Back then I reviewed the code for optimizations and had couple of ideas, but I ran into some other problems when trying to implement those. I'll check your suggestion and the code again to see if some improvements could be made (btw the code in bierdopjesubtitles.zip is not same as line-to-line that in SubtitleDownloader)

    EDIT: I'm not sure where you want me to use GetAllSubsFor ? It seems to be internal method that cannot be called from my code? I could have also used GetEpisodeById which is internal too in the SaveSubtitle() implementation..
     

    Users who are viewing this thread

    Top Bottom