Subtitles issues v1.3.0.0 (1 Viewer)

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    When talking with Tourette about the issue :
    1) D3DERR_INVALIDCALL - more infor would be needed. He needs to use DirectX debug logging from the DirectX itself to be able to see why the call is invalid
    2) Timeout=1,84467440737096E+19 <--- almost infinite subtitle timeout - not sure how it can happen

    Since all is working with DVBSub2 but maybe something wrong with DirectX and new implementation in DVBSub3.
     

    burr

    MP Donator
  • Premium Supporter
  • May 13, 2006
    175
    47
    Home Country
    Sweden Sweden
    I have tested your build to fix the enumeration exception and this error is not there anymore but the directx exceptions still remain.

    I have also tested to do a clean install of the client but still the same.
     
    Last edited:

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Last edited:

    burr

    MP Donator
  • Premium Supporter
  • May 13, 2006
    175
    47
    Home Country
    Sweden Sweden
    Do i have to download directx SDK to get to debug mode, i can't move the slider when i open "directx.cpl"?
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,583
    10,403
    France
    Home Country
    France France
    Ah good question, it's possible i have the sdk and i can move the slider.
     

    burr

    MP Donator
  • Premium Supporter
  • May 13, 2006
    175
    47
    Home Country
    Sweden Sweden
    The SDK was the trick here is the logs

    00020862 20:46:06 [3524] Direct3D9: (ERROR) :D3DUSAGE_DYNAMIC cannot be used with managed vertex buffers
    00020863 20:46:06 [3524]
    00020864 20:46:06 [3524] Direct3D9: (ERROR) :Failure trying to create Vertex Buffer
     

    Scythe42

    Retired Team Member
  • Premium Supporter
  • June 20, 2009
    2,065
    2,703
    50
    Berlin
    Home Country
    Germany Germany
    Dynamic Textures cannot be used with a managed D3D Pool. Or in D3D terms. D3DUSAGE_DYNAMIC and D3DPOOL_MANAGED are incompatible.

    In this case it's about the Vertex Buffers. Static Vertex Buffers are placed into video memory and dynamic ones in the AGP memory. If D3DUSAGE_DYNAMIC is not specified the vertex buffers are made static.

    The only reason to use dynamic vertex buffers is that you don't have to lock them. Locking has huge performance penalties as the lock forces a wait until the GPU finished reading vertex/inde data from the buffer before control is given back to an app. Locking a static buffer several times per frame prevents the GPU from buffering rendering commands. Without buffered commands the GPU remains idle until the app finished filling the vertex buffer/index buffer.

    Normally the vertex or index data should not change. There are of course applications where this is needed on every frame. This is the only reason to use D3DUSAGE_DYNAMIC.

    So if we don't change vertex/index data no need of D3DUSAGE_DYNAMIC should be given. Need to take a look at the code itself what we do with the vertex buffers. But honestly the vertex buffer should be the always the same. At least during one frame. Locking between frames would be OK, but still has performance penalties.

    Subtitles should be rendered to a texture, and the texture is displayed with the same vertices anyway. Don't really see the need to change the vertices here. Rendering each letter as it's own object would be a bit of an overkill. Rendering them to a texture and them pumping this texture to the GPU should be faster.

    I need to take a look at the code itself to see what we are doing. But if this can be fixed easily I guess as it seems to be introduced recently. But let me take a look at the code first.

     

    burr

    MP Donator
  • Premium Supporter
  • May 13, 2006
    175
    47
    Home Country
    Sweden Sweden
    Dynamic Textures cannot be used with a managed D3D Pool. Or in D3D terms. D3DUSAGE_DYNAMIC and D3DPOOL_MANAGED are incompatible.

    In this case it's about the Vertex Buffers. Static Vertex Buffers are placed into video memory and dynamic ones in the AGP memory. If D3DUSAGE_DYNAMIC is not specified the vertex buffers are made static.

    The only reason to use dynamic vertex buffers is that you don't have to lock them. Locking has huge performance penalties as the lock forces a wait until the GPU finished reading vertex/inde data from the buffer before control is given back to an app. Locking a static buffer several times per frame prevents the GPU from buffering rendering commands. Without buffered commands the GPU remains idle until the app finished filling the vertex buffer/index buffer.

    Normally the vertex or index data should not change. There are of course applications where this is needed on every frame. This is the only reason to use D3DUSAGE_DYNAMIC.

    So if we don't change vertex/index data no need of D3DUSAGE_DYNAMIC should be given. Need to take a look at the code itself what we do with the vertex buffers. But honestly the vertex buffer should be the always the same. At least during one frame. Locking between frames would be OK, but still has performance penalties.

    Subtitles should be rendered to a texture, and the texture is displayed with the same vertices anyway. Don't really see the need to change the vertices here. Rendering each letter as it's own object would be a bit of an overkill. Rendering them to a texture and them pumping this texture to the GPU should be faster.

    I need to take a look at the code itself to see what we are doing. But if this can be fixed easily I guess as it seems to be introduced recently. But let me take a look at the code first.


    Have you had any time to look at the code?
     

    Users who are viewing this thread

    Similar threads

    @CyberSimian Thank you very much. That has worked!!
    @CyberSimian Thank you very much. That has worked!!
    Do live TV subtitles work for TV in Australia? If so what are the settings? I am a 74 year old with hearing impairment and have...
    Replies
    12
    Views
    993
    This is not possible, only on the bluray present subtitles can be selected. Same as above. Audio streams can never be selected apart from the merged ones. You'll have to use tools like the mentioned Media-Buddy to achieve that. Subtitles of local media can be placed into the same folder (with the same name) into the video file. You...
    This is not possible, only on the bluray present subtitles can be selected. Same as above. Audio streams can never be selected...
    Hi, is it possible to include downloaded subtitles during Bluray playback? While playing a Bluray, i can open the menu to select...
    Replies
    1
    Views
    773
    Thank you. I had a look at that part of the menu, but there's no option for DVB subtitles. Probably it has something to do bit some issue of MP2 with PGS subtitles that I've read in several posts. Although I don't know if DVB subs are also PGS subs. I guess that it will be fixed in future versions of MP2. Anyway, if somebody is...
    Thank you. I had a look at that part of the menu, but there's no option for DVB subtitles. Probably it has something to do bit...
    Hi, I changed recently from MP1 and MPS. Very happy, no matter I have to struggle with a few issues like this one: When I watch...
    Replies
    2
    Views
    866
    I reinstalled 1.24 to get it back, however it was not included in that distro. I have no idea how I got that application in the first place. Anyway I got it back as described here above. I can send you the executables if you like. Let me know.
    I reinstalled 1.24 to get it back, however it was not included in that distro. I have no idea how I got that application in the...
    Hi all, Not a rant, more a sharing of experience (maybe hoping to get some clarification on which wrong turn I took) It has been...
    Replies
    8
    Views
    604
    Thanks for the info. Now I know how to create logs. I remapped the keys and, for the moment, after using MP2 several times, they function well. If the mapping disappears again, I'll send you some logs. Thank you!
    Thanks for the info. Now I know how to create logs. I remapped the keys and, for the moment, after using MP2 several times, they...
    Hi, I changed recently from MP1 to MP2 and I'm very happy with the change. But I still have to learn quite a few things. Sorry if...
    Replies
    4
    Views
    879
    Top Bottom