switch to a new logging framework (Log4Net) (1 Viewer)

[HomeY]

So, what do we do?

If we are going to follow our new development model, then reverting this and putting it into 1.4.0, as we had intended, is not so bad.

I think that is what we have to do.

Agree, stick to the plan, revert merge and schedule for 1.4

 

[elliottmc]

So, what do we do?

If we are going to follow our new development model, then reverting this and putting it into 1.4.0, as we had intended, is not so bad.

I think that is what we have to do.

Agree, stick to the plan, revert merge and schedule for 1.4

@Sebastiii - could you please do this?

 

[Sebastiii]

Hi
I'm ready to push the revert of log4net.
Seb.

 

[elliottmc]

Hi
I'm ready to push the revert of log4net.
Seb.

Go for it. Sorry @Bavarian, but too risky at this point. However, this is the first thing in to 1.4.0 !

 

[tourettes]

It's not too late to revert it but make ugly master log.

Having an ugly history in GIT is less serious than having some code that wont belong there. Just remember to revert instead of reseting one commit in master and then force pushing to public

 

[Sebastiii]

Sure thx

 

[Bavarian]

Hi
I'm ready to push the revert of log4net.
Seb.

Go for it. Sorry @Bavarian, but too risky at this point. However, this is the first thing in to 1.4.0 !

Please decide next time first and then push the start trigger!

 

[elliottmc]

Hi
I'm ready to push the revert of log4net.
Seb.

Go for it. Sorry @Bavarian, but too risky at this point. However, this is the first thing in to 1.4.0 !

Please decide next time first and then put the start trigger!

I did. I scheduled it in mantis for 1.4.0. Then you said you consider this ready for merge, and Homey and Seb got a bit excited.

Basically, there was never any intention (on my part) to push this into 1.3.0, but after all the work you have done I wanted to make sure it was scheduled for 1.4.0 so it wouldn't be delayed any longer. I fully understand your frustration. This was just a bit of a misunderstanding.

Best wishes,

Mark

 

[Bavarian]

I did. I scheduled it in mantis for 1.4.0. Then you said you consider this ready for merge, and Seb got a bit excited.

Basically, there was never any intention (on my part) to push this into 1.3.0, but after all the work you have done I wanted to make sure it was scheduled for 1.4.0 so it wouldn't be delayed any longer. I fully understand your frustration. This was just a bit of a misunderstanding.

Best wishes,

Mark

I understand. Thx Mark

 

[HomeY]

Please decide next time first and then push the start trigger!

I did. I scheduled it in mantis for 1.4.0. Then you said you consider this ready for merge, and Homey and Seb got a bit excited.

Sorry Manfred, i forgot that the Train model will take affect as of MP v1.4 and since i tested this a long time ago (as did others) and you agreed it was tested enough, i thought we were good.

My bad!!