Thumbnail generation - design problem: thumbnails are almost same and not very informative. (4 Viewers)

[Sebastiii]

I have found a bug. I think it is in the 1.4.0 stable too.

When there is no thumb in the cache.

1. Change to list view.
2. Stay on a move which still there is not thumbnail yet.
3. Wait for thumbnail is generated.
4. The small thumb is refreshed but the large thumb stay empty.
5. If you move to another move and move back, the large thumb freshed too.

View attachment 133342​

Hi

Did you work/update the video part code ? I just read my locked SD card and ffmpeg was running but failed because MP can't write to it.
So use temp folder when created single picture and global would be nice

EDIT : Does we need command line addon on ffmpeg to tell to us temp folder ?

If we can sort out this, we can port the code to TV side ?
Thanks

Ps : About above error, i didn't try to debug it lol

 

[Sebastiii]

I have adapted to use Temp folder, if you can look if it's ok and test
Then i can commit to the branch and you can finish the tv side ?

Thanks

 

[regeszter]

I have adapted to use Temp folder, if you can look if it's ok and test
Then i can commit to the branch and you can finish the tv side ?

Thanks

Pls comit your changes. You are a developer, so I think your solution is ok.

To port into the tv server solution is not too easy. There are some method in MP but which is not in TV server.

 

[Sebastiii]

I have updated the branch

 

[Sebastiii]

I have adapted to use Temp folder, if you can look if it's ok and test
Then i can commit to the branch and you can finish the tv side ?

Thanks

Pls comit your changes. You are a developer, so I think your solution is ok.

To port into the tv server solution is not too easy. There are some method in MP but which is not in TV server.

I'm from Dev group but i'm not a strong Dev (my skill is not high lol) I'm more a tester with debug capability

 

[regeszter]

I have found a bug. I think it is in the 1.4.0 stable too.

When there is no thumb in the cache.

1. Change to list view.
2. Stay on a move which still there is not thumbnail yet.
3. Wait for thumbnail is generated.
4. The small thumb is refreshed but the large thumb stay empty.
5. If you move to another move and move back, the large thumb freshed too.

View attachment 133342​

Hi,

this is a workaround for this bug. I can not find the root cause.

 

[regeszter]

just for Sebastiii

 

[Sebastiii]

Thanks will look ASAP

 

[regeszter]

Hi Sebastiii,

pls add to the VideoThumbCreator.cs (mp & tv server):

if (preGapSec > Duration)
{
preGapSec = Duration - 240;
}

if (preGapSec <= 0)
{
preGapSec = 4;
}

thnx

 

[Sebastiii]

Hi,

I have pushed the branch with the TV Part updated.
Can you try ?

Thanks