Thumbnail generation - design problem: thumbnails are almost same and not very informative. (1 Viewer)

[Sebastiii]

I will create a branch with your change
I have do some cleanup of whitespace / revert tv solution (not needed right) and put in back EOL to Unix for somes files to have a better diff patch in GITHUB commit log

 

[Sebastiii]

Branch created : https://github.com/MediaPortal/Medi...ration_Thumbnail_for_TV_Movie_based_on_lenght

@regeszter can you post a summarize of the latest patch to update the wiki

 

[regeszter]

Branch created : https://github.com/MediaPortal/Medi...ration_Thumbnail_for_TV_Movie_based_on_lenght

@regeszter can you post a summarize of the latest patch to update the wiki

Time offset in minutes: at the generation of the thumbnails the user can exclude a part of the video from the beginning.

The thumbnails will be generated after time offset up to 30 minutes. Should the video duration be less than the time offset, the time offset is automatically shorter.

The thumbnail can be refreshed from the context menu. The new thumbnails will be generated after time offset + (10 to 120 seconds random value).

 

[regeszter]

@Sebastiii,

please update the branch with the attached file. I have found a wrong behaviour in my code.

Thanks for advance!

 

[Sebastiii]

Will do ASAP

 

[Sebastiii]

Can you directly work on the 'MP1-4090-Generation_Thumbnail_for_TV_Movie_based_on_lenght' branch ?
Will be more easy to mantain (for me )

About CRLF and LF (MP is mixed between both), i don't know if you have the message from VS about changing EOL (End of line), it's needed to answer 'No' to keep actual CRLF/LF otherwise when commit, it will look like the whole files has changed.

@ some point, we need to change all MP files to avoid this lol

Thanks

 

[regeszter]

Can you directly work on the 'MP1-4090-Generation_Thumbnail_for_TV_Movie_based_on_lenght' branch ?
Will be more easy to mantain (for me )

About CRLF and LF (MP is mixed between both), i don't know if you have the message from VS about changing EOL (End of line), it's needed to answer 'No' to keep actual CRLF/LF otherwise when commit, it will look like the whole files has changed.

@ some point, we need to change all MP files to avoid this lol

Thanks

How can I write the branch? When I change the

Read-Only Access: git://github.com/MediaPortal/MediaPortal-1.git
to
Read+Write Access: git@github.com:MediaPortal/MediaPortal-1.git,
the git showes the following error.

git.exe pull -v --progress "Mediaportal"
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
thx

 

[Sebastiii]

Hi,

You can't write to branch, only dev can write to MediaPortal-1, but you can create your own account and fork MediaPortal-1 repo and you can write to your copy

Or switch on 'MP1-4090-Generation_Thumbnail_for_TV_Movie_based_on_lenght' from 'MediaPortal-1' repo and work locally on this branch and copy file here, i can commit it.

 

[regeszter]

Ok. I synchronized my local copy with 'MP1-4090-Generation_Thumbnail_for_TV_Movie_based_on_lenght' from 'MediaPortal-1' .

 

[Sebastiii]

Hi,

It seems we run in performance issue CPU Usage is 100% for me on my Core 2 Duo laptop.
We update the Jira Ticket, can someone confirm it ?

I remember when working on this (based on Jay_UK command line) we try different command line but keep that one that generate thumb very fast.

Can we handle it better ?

Thanks