Upgrade to 1.13.0 and the DefaultWideHD skin (4 Viewers)

wizard123

Retired Team Member
  • Premium Supporter
  • January 24, 2012
    2,523
    2,715
    Home Country
    United Kingdom United Kingdom
    In fact it works like this :
    When a upgrade is started, NSIS installer backup SkinSettings.xml, copy all skin files and at final restore SkinSettings.xml.
    It doesn't backup other xml files only SkinSettings.xml :)
    But does it do what MM suggested and check whether a new setting has been added and if so add that setting to the backed up file ?
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,523
    10,466
    France
    Home Country
    France France
    I'm not following. It does backup and restore when doing a re-install ; )
    So I suppose not lol.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,523
    10,466
    France
    Home Country
    France France
    My previous post was made with my phone :)

    So, installer take a snapshot of SkinSettings.xml and restore it after installer copy all files.
    So the SkinSettings.xml is always the same as before the installer make his magic :)

    But if you change something on SkinSettings.xml when using MP as normal, there is no autobackup of it. I'm not sure i'm clear or maybe i didn't understand you both lol.
    But if you upgrade MP, SkinSettings.xml will stay the same.

    Ah now will writing, i think i understand you (it take me time), you mean that if a new setting is needed in the SkinSettings.xml from the installer then no, it will not be added (the installer NSIS didn't analyse the xml, it just backup the file and put it back).

    So in final no new setting should be added now :) :) :) :) lol of lol. (Joking aside, if there is a new setting, then i hope it will not break the skin because it will not be taking in account)
     

    mm1352000

    Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,544
    8,236
    Home Country
    New Zealand New Zealand
    But does it do what MM suggested and check whether a new setting has been added and if so add that setting to the backed up file ?
    To be clear: I was not suggesting that the installation script (which is what Sebastiii is talking about) should do this. Rather, I was suggesting that skins (or whatever uses that file) should be robust enough to cope when a setting is not present. When a setting is not present, they should use a sensible default value and add the setting etc. etc. etc.
     

    wizard123

    Retired Team Member
  • Premium Supporter
  • January 24, 2012
    2,523
    2,715
    Home Country
    United Kingdom United Kingdom
    But does it do what MM suggested and check whether a new setting has been added and if so add that setting to the backed up file ?
    To be clear: I was not suggesting that the installation script (which is what Sebastiii is talking about) should do this. Rather, I was suggesting that skins (or whatever uses that file) should be robust enough to cope when a setting is not present. When a setting is not present, they should use a sensible default value and add the setting etc. etc. etc.
    Yep Apollo checks it's own settings on skin update and adds any new ones that are missing but i just wanted to confirm the default behavior of the installer.
     

    Users who are viewing this thread

    Top Bottom