1.27.0 5059: Performance stats displayed incorrectly (1 Viewer)

[doskabouter]

MP1 Version

Just upgraded to 1.27 and when showing performance stats (shift-1) the text is not readable.
It looks like just the lower 3 or 4 pixels of the text is shown.
Anyone else has this issue?

 

[Sebastiii]

In EVR, it's not readable
I have posted a screenshot, so I can confirm the issue, something with DPI or else lately has made a regression lol (can't find it)

Thanks for opening bug thread

 

[doskabouter]

Thanks for confirming it's not just me.
I'll see if I can repro this on my devpc and let git-bisect do the rest

 

[doskabouter]

narrowed it down to MP1-5043: Upgrade to Visual Studio 2019 · MediaPortal/MediaPortal-1@e3df8f4
specifically the changes in dshowhelper (MP1-5043: Upgrade to Visual Studio 2019 · MediaPortal/MediaPortal-1@e3df8f4)
but I don't yet know the deeper meaning and pitfalls of the std::use_facet<fac >(loc) stuff.
if anybody has a deeper knowledge of c++ please let me know.
I'm going to see if I can find out what this all means

 

[doskabouter]

ok, that remark about MP1-5043: Upgrade to Visual Studio 2019 · MediaPortal/MediaPortal-1@e3df8f4 isn't correct.
if I apply these changes to the last working commit (MP1-5038: fix copyfiles mediainfo wrapper to bin folder for testing m… · MediaPortal/MediaPortal-1@2a029f2) it still works ok.
That would put the blame on vs2015 <-> vs2019 compilation...

Edit:
Yup, switching the platform toolset from "Visual Studio 2015 (v140)" to "Visual Studio 2019 (v142)" breaks it.
Choosing "Visual Studio 2017 (v141)", then it works. so the breakage is between 141 and 142

Edit2: compiling dshowhelper shows 104 warnings (with v140, v141 as well as v142 so no extra ones to check). And none of them stand out to point to the issue at hand...

 

[Sebastiii]

Good find now why it happens, will be hard to track

 

[doskabouter]

Really strange, I should expect only a change in the toolset wouldn't have that much influence... I mean, it compiles and no extra warnings.
That could possibly happen to anyone, so any c++ project upgrading it's toolset could potentially break in non-expecting places...
So either we do some really nasty things in dshowhelper, or microsoft messed up... (Don't know for which one I'm rooting )

 

[Sebastiii]

Yeah, It looks like a bug on MS, but maybe because they change something and then dshowhelper need to be adapted, but why and where ?

 

[doskabouter]

Found it and fixed it: MP1-5059 Performance stats displayed incorrectly: removed cast and us… · MediaPortal/MediaPortal-1@98c312f

Loading...

issues.team-mediaportal.com

 

[Sebastiii]

You are the best