[Approved] Fix for TVE #0002126 (1 Viewer)

[framug]

This patches are for 0002126: HardDisk Full -> "no video/audio detected" - MediaPortal Bugtracker

 

[framug]

Since I tested it on a USB key, I found better cartridges for my rifle.
And, here are the evidences (screenshots before/after) :

I modified older classes wich are now for latest #23143 SVN.

 

[tourettes]

Actually it would be more important to fix the MediaPortal client side to show the correct error note when the disk is full.

 

[framug]

Hi tourettes,

Ah, OK, it was not very clear, in the mantis.
May I hope this fix will be integrated anyway ?
Then I didn't work for nothing ?
I will have a look on the client side but, I don't promise something for sure.

 

[morpheus_xx]

I think it's also important to handle disk space also during recording and timeshifting, not only on starting.

does your patch cover this?

 

[framug]

Hi morpheus,

I admit not, for the server side but, I would like to explain you what I found :

For the server side :
TimeShifter doesn't want to start if there is less space than 488,5 MB.
I'm absolutely sure of that because fully tested.
The TimeShift file is always 250 MB.
Then, for this event, user has to stay on record state in the TV-Server Configuration during more than 7 minutes.
And even if more than 7 minutes, the TV-Server doesn't crash.
Of course, in this case, .ts file will not be really usable but, click record button on Manual Control Form, isn't it intended only for testing if record is OK, finally ?
Then, shouldn't it be enough, just for this case ?
Don't forget, before, it was a messagebox with another message displayed but, there was neither specific thread or timer for that too.
Then, I thought it was just a bug to fix.

For the client side, it's not the same error message (look at screenshot) :
It appears to be inside TVHome.cs, when ChannelTuneFailedNotifyUser(TvResult succeeded, bool wasPlaying, Channel channel) method is called.
Then, shouldn't it be another mantis record for that ?
(Just wonder and of course, I agree, we have to fix it too).

What do you think, about ?

Edit : ooops, just seen that unknown error, is because of the new NoFreeDiskSpace implemented and, not treated yet in TVHome.
I must to look a bit more inside.

 

[framug]

Enjoy Client side :

 

[morpheus_xx]

shouldn't your patch consider also the settings from tvservice?

i.e. you can set timeshift file size to 1 GB per file, min 2, max 4. your hardcoded check "<500000" wouldn't fit here.

I think this should be possible to check?

 

[framug]

morpheus, sorry to ask you this.
Remember, I'm a bit noob, with this TVE3.
I didn't know there were such settings.
Is it what I surrounded in red and green ?
I have to multiply Minimum files with Filesize to obtain the value and finally use it in the test ?
Is it what you ask me for ?

Edit : Well, or maybe, I suppose multiply Maximum files with Filesize, isnt it ?

 

[framug]

After many tests :

- Changing Minimum or Maximum files settings doesn't change disk space needed.
- Only changing Filesize is influential with disk space needed.
A 256 MB/file value in Filesize implies 512 000 000 bytes free on HDD for it works.
(488 MB exactly because, you know of this story for bad commercial disk size, they count 1 KB = 1000 Bytes and 1 MB = 1000 KB).
A 257 MB/file value in Filesize implies 514 000 000 bytes free on HDD for it works.

Then, I determined this calcul solution for it works :

Error No Free Disk Space if :

Free Disk Space on HDD < (timeshiftMaxFileSize in Bytes * 2)


I uploaded newer TimeShifter.patch in the first post, if you agree with my solution...