Let use, they are in the case of source code changes will have the color of which was conceived by the author rather than the default color.
if (valueText.Length > 0)
{
bool isNamedColor = false;
bool isSharp = false;
if (valueText[0] == '#' && valueText.Length > 1)
{
valueText = valueText.Substring(1);
isSharp = true;
}
foreach (char ch in valueText)
{
if (ch >= '0' && ch <= '9' || ch >= 'A' && ch <= 'F' || ch >= 'a' && ch <= 'f')
{
continue;
}
isNamedColor = true;
break;
}
if (isNamedColor && isSharp) // Property
{
valueText = "#" + valueText;
}In MP Wiki, Color can have a value:
New Zealand
Great.Well, I have eliminated all use of the "#" in colours (mostly, but not entirely, in code that I had added or modified), and... it now all works as expected.
Sorry, I will not support this change because:
Why not? If I want a green apple, green apple I take, and I do not take the yellow lemon. If a designer wanted #AARRGGBB, he watched the color table, and knew what he wanted. If he had turned a different color then it would open a topic about it, as did @CyberSimian.
Nothing changes:
How not? Media portal only supports hexadecimal color, and only in the alpha channel for a named colors supports both formats.
The procedure is not processing this symbol, if the system is able to determine the standard color, or if the color is in the cache, then we get what we wanted, or we'll get the default color that is white. But if you make the changes, then we will get the color as described in the wiki. Note the color value is not provided by the property.This is evident from the source code.
New Zealand
I already explained!
If I give you a yellow lemon when you ask for a green apple, I will assume that the yellow lemon is okay if you don't complain. You should have complained if the green apple was really important.
Yes, I agree... but if the skin engine gives the designer black instead of AARRGGBB and the designer does not complain, the designer must think that black is okay too. Now after X years the designer and people who use the designer's skin expect black. If you change the black to AARRGGBB, the designer and users will be angry with you. It's much easier to fix the wiki and say that #AARRGGBB is not a valid colour value. That way the skin engine will stay the same and nobody will be angry.
Of course something changes!
You know that MP only supports HEX colours... but other people do not. CyberSimian already thought # means HEX and no # means DECIMAL. If you add support for #AARRGGBB, even more people will be confused.
But other earlier procedures do! # means skin engine defined value (eg. BasicHome.xml: <define>#selecteditem:</define> etc.):
White, not Black - return Color.White.ToArgb();
Since no one complains, then all got a green apple. In addition to @CyberSimian , he is complaining.
Designer, replace the #AARRGGBB on White, it is not difficult. The more so because the designer does not always get the white, it is in the case of falling into the standard colors to get the color he wanted.
White or AARRGGBB ...
Why is described above.If they read the documentation that is written in it all.
This is another property. It does not refer to the color.
I also said when I made corrections to the FH, LMH, if I did not correct these plug-ins are not sure that they would work. The same is true about MP1-4715. MP1-4831 etc.
New Zealand
Black, not white!
return colCache.TryGetOrAdd(valueText, col => Color.FromName(valueText)).ToArgb();This code will never be reached in the case of #AARRGGBB. isNamedColor must be true because of the #. Try it and you will see.return Color.White.ToArgb();
United Kingdom
Indeed some do i have seen it many times before over the years.