[solved] Latest Media Handler Additional facade controls (2 Viewers)

[ajs]

I rework facade detect procedure (but i dont test)... plz try...

Run MP, wait, if not facade switch to other window like Home or other. Then switch to Basic Home, wait and check.
Stop MP and give me plz debug log.
Thanks!View attachment LatestMediaHandler.dll.Alpha.VII.zip

--
WBR, ajs

 

[ajs]

At startup, the plugin can not find the facade

Very strange ...
I create test function for facade determine,

facade = gw.GetControl(ControlID) as GUIFacadeControl;

if facade == null, then function print all children control and i get:
On startup:

22-Jan-2018 22:46:25 Debug [LatestMyVideosHandle]: *** InitFacade: LatestMyVideos: 1 
22-Jan-2018 22:46:26 Debug [               Utils]: GetLatestsFacade: Unable to find facade control [id:919198710].

In Children List no control with ID = 919198710

But if i switch to Home window and back, i give:

22-Jan-2018 23:02:53 Debug [               Utils]: GetLatestsFacade II: Control [id:919198710] - MediaPortal.GUI.Library.GUIFacadeControl - MediaPortal.GUI.Library.GUIFacadeControl 
...
22-Jan-2018 23:02:53 Debug [               Utils]: GetLatestsFacade: Found facade control [id:919198710]. 
...
22-Jan-2018 23:02:53 Debug [               Utils]: *** UpdateFacade: 919198710 - Filmstrip

And all work fine ...


@Developers @Sebastiii need help, why on startup not all control in Children list?
May be MP1-4887 made some changes, and it is necessary to define something like that on another. Previously it worked perfectly. But in what version I do not remember.

Spoiler: All code:

    /// <summary>
    /// Check if Window fully loaded
    /// </summary>
    /// <param name="self"></param>
    public static bool WindowIsLoaded(this GUIWindow self)
    {
      int _focused = self.GetFocusControlId();
      // logger.Debug("*** WindowIsLoaded: W: {0}  - {1}:{2}", self.GetID, self.WindowLoaded, _focused > 0);
      return self.WindowLoaded && _focused >= 0;
    }

    internal static GUIFacadeControl GetLatestsFacade(int ControlID)
    {
      if (GUIWindowManager.ActiveWindow <= (int)GUIWindow.Window.WINDOW_INVALID)
      {
        return null;
      }

      GUIWindow gw = null;
      lock (lockObject)
      {
        try
        {
          do
          {
            gw = GUIWindowManager.GetWindow(GUIWindowManager.ActiveWindow);
            if (gw == null)
            {
              return null;
            }

            ThreadToSleep();
          }
          while (!gw.WindowIsLoaded());
        }
        catch (Exception ex)
        {
          logger.Debug("GetLatestsFacade: " + GUIWindowManager.ActiveWindow);
          logger.Error("GetLatestsFacade: " + ex);
        }

        int i = 0;
        GUIFacadeControl facade = null;
        try
        {
          bool bReady;
          do
          {
            facade = gw.GetControl(ControlID) as GUIFacadeControl;
            if (facade == null)
            {
              i++;
              bReady = false;
              Thread.Sleep(100);
            }
            else
            {
              bReady = true;
            }
          }
          while (i < 5 && !bReady);
        }
        catch (Exception ex)
        {
          logger.Debug("GetLatestsFacade: " + GUIWindowManager.ActiveWindow + " - " + ControlID);
          logger.Error("GetLatestsFacade: " + ex);
        }

        if (facade == null)
        {
          logger.Debug("GetLatestsFacade: Unable to find facade control [id:{0}].", ControlID);
          facade = gw.Children.GetControlById(ControlID) as GUIFacadeControl;
          if (facade == null)
          {
            foreach (GUIControl c in gw.Children)
            {
              if (c.GetID > 0)
              {
                logger.Debug("GetLatestsFacade II: Control [id:{0}] - {1} - {2}", c.GetID, c, c.GetType());
              }
              if (c.GetID == ControlID)
              {
                facade = c as GUIFacadeControl;
                if (facade == null)
                {
                  logger.Debug("GetLatestsFacade III: Unable to find facade control [id:{0}].", ControlID);
                }
                else
                {
                  logger.Debug("GetLatestsFacade III: Found facade control [id:{0}].", ControlID);
                }
              }
            }
          }
          else
          {
            logger.Debug("GetLatestsFacade II: Found facade control [id:{0}].", ControlID);
          }
        }
        else
        {
          logger.Debug("GetLatestsFacade: Found facade control [id:{0}].", ControlID);
        }
        return facade;
      }
    }

 

[wizard123]

Very strange, i hope the guys can help you because this has huge potential for skin designs.

 

[Sebastiii]

@ajs can you try to revert MP1-4887 : Fix regression introduce from MP1-4887 (https://forum.team… · MediaPortal/MediaPortal-1@b2d536c · GitHub ?
There are 2 commits for it. Yep maybe this is MP1-4887 that breaking it, so to be sure, this need to be tested against the change.

After that if it's not this, it's more hard to find the culprit and it's needed to start from old MP version and build each new merge and find where the issue occurs

 

[ajs]

There are 2 commits for it. Yep maybe this is MP1-4887 that breaking it, so to be sure, this need to be tested against the change.

All LMH controls in Titanius skin in include xml ...

<include condition="#(plugin.isenabled('Latest Media Handler'))">BasicHome.LatestMyVideosFacade.xml</include>

Maybe delay load? Or? Background in thread?
I dont Debug MP with LMH on my test computer ...

 

[Sebastiii]

Me too but i can try if i know what/where/how to do lol

 

[ajs]

but i can try if i know what/where/how to do lol

I can give either the library or the source code completely. Skin Titanius. The GatLatestsFasade procedure in the Units module.

 

[ajs]

Current Test Version ...

 

[ajs]

Implemented in LatestMediaHandler 2.4.0.66