[Rejected] Some Videos with remote ftp Problems (1 Viewer)

[framug]

Re : Re: Some Videos with remote ftp Problems

Moved back to pending

Hi Silent,
for keeping me informed about it.

Perhaps original dev who looked at this patch could take another look?

imho, no need cause, I analysed code deeply for that and, it can't have bad side effect.
Also, because more than 230 users use it (and many other stuff) since 6 or 7 months without side effect too.
Of course, this one is just a very little improvement.
But, if it is a Team decision...
Regards.

 

[elliottmc]

I've had a look at this thread and the one linked in the first post, and I am not at all clear what problem this patch is supposed to fix.

Could someone please explain this, as it might help us reach a decision about whether to include it in 1.2.0beta?

Thanks,

Mark

 

[Deda]

Actually this is not needed anymore and was repaired in SVN 26039

current SVN Util.cs line 646
------------------------------------
if (Path.IsPathRooted(item.Path) && IsVideo(item.Path) && !VirtualDirectory.IsImageFile(Path.GetExtension(item.Path).ToLower()))
------------------------------------

and in followed SVN changes in Virtual Directory (I tested ftp as default with current SVN code and can't manage to crate thumb) :


MP will not play files from ftp, but it will ask to download it locally and play, after thumbs are created without problem for that file.