[Rejected] Some Videos with remote ftp Problems (1 Viewer)

[framug]

Discussed here :

https://forum.team-mediaportal.com/...a-1-454/ftp-video-folder-default-fails-73451/

 

[chemelli]

PMed morpheus_xx about this patch.

Simone

 

[morpheus_xx]

AW: Some Videos with remote ftp Problems

Hi framug,

I checked your patch against current svn.

the first part in Util.cs is still ok (avoid thumb for remote, but the 2nd one doesn't match anymore.

do you think that it is still required? there also was a switch in directory accessing function to Win32 calls...

can you post a current patch for virtualdirectory.cs, if required?

 

[framug]

Re : Some Videos with remote ftp Problems

Hi,
If I look inside GetDirectoryUnProtectedExt method, I would say yes, it's necessary yet.
Now, there is a if (IsRemote(strDir)) test for getting FTP files but, without return, I'm wondering why doing HandleLocalFilesInDir would be necessary.

can you post a current patch for virtualdirectory.cs, if required?

 

[chemelli]

framug, morpheus_xx,

can you tell me what is the status of this please ?

Simone

 

[framug]

Re : Some Videos with remote ftp Problems

I can't tell you more that I see the discussion around this patch is almost one year old and it has never been commited, nor discussed deeper.

 

[elliottmc]

Re: Re : Some Videos with remote ftp Problems

I can't tell you more that I see the discussion around this patch is almost one year old and it has never been commited, nor discussed deeper.

Yes, but Simone is trying to push this to reach a decision, so are you able/willing to help?

Does the patch still work against current SVN? Is the bug still there?

Mark

 

[framug]

Re : Re: Re : Some Videos with remote ftp Problems

Yes, but Simone is trying to push this to reach a decision, so are you able/willing to help?

I always tried to help, no problem.

Does the patch still work against current SVN? Is the bug still there?

Mark

Hi Mark,
The bug is still here cause, it has never been commited.
Therefore, I can't tell you if the posted code is still "alive" cause, I let or updated it (or Tortoise merged it) for MP 1.1.1 and/or MP 1.2.0 for my own release and, I don't remember if MP devs changed those classes since one year

 

[framug]

Re : Some Videos with remote ftp Problems

This patch is an updated one against latest SVN, same code for both MP 1.1.1 and 1.2.0.

As usual, please, just remove few comments (needed when classes conflicts).

 

[SilentException]

Moved back to pending Perhaps original dev who looked at this patch could take another look?