Thumbnail generation - design problem: thumbnails are almost same and not very informative. (3 Viewers)

[markus_g]

Ok i have found the culprit and this issue is a regression introduce in ffmpeg rework and trigger when using 'enable file existence cache' option
Should be fixed now

Great work . I just remembered I turned off file existence cache a couple of days ago. I tried turning it off due to if I was quickly stepping through video files thumbnails would disappear altogether and then if I escaped back and went back in they would return.
Regards,
Markus.

 

[Sebastiii]

Great work . I just remembered I turned off file existence cache a couple of days ago. I tried turning it off due to if I was quickly stepping through video files thumbnails would disappear altogether and then if I escaped back and went back in they would return.
Regards,
Markus.

Hey, I'm not sure to follow you lol, you mean with option off, no more thumbnail stay but back in folder, they are back ?

 

[markus_g]

Great work . I just remembered I turned off file existence cache a couple of days ago. I tried turning it off due to if I was quickly stepping through video files thumbnails would disappear altogether and then if I escaped back and went back in they would return.
Regards,
Markus.

Hey, I'm not sure to follow you lol, you mean with option off, no more thumbnail stay but back in folder, they are back ?

What I mean is when file existence cache is enabled the following happens.

1) Turn on file existence cache.
2) go into a video folder using mypictures.
3) step down on each video file and the thumbnail is displayed.
4) after going through the entire folder the thumbnails are no longer viewable or some are and some arn't.
5) press escape.
6) go back into folder and the video thumbnails are back again.

 

[Sebastiii]

Can you try on next bin (i will PM you because based on current Master) and see if it's better for you ?
Sorry to be offtopic because thumbnail issue happen on 1.4.0 release and it was not related to ''regeszter' patch

@regeszter :

You can see the change i have done in \mediaportal\Core\Util\VideoThumbCreator.cs :

		if (aCacheThumb && Success)
		{
		  if (Picture.CreateThumbnailVideo(ShareThumb, aThumbPath, (int)Thumbs.ThumbResolution, (int)Thumbs.ThumbResolution,
									  0, false))
		  {
			Picture.CreateThumbnailVideo(ShareThumb, Utils.ConvertToLargeCoverArt(aThumbPath),
									(int) Thumbs.ThumbLargeResolution, (int) Thumbs.ThumbLargeResolution, 0, false);
		  }
		}

That bottom part has to be removed :

		  if (!Util.Utils.FileExistsInCache(ShareThumb))
		  {
			return false;
		  }

Thanks

 

[regeszter]

Hi,

This version uses the Time offset to skip the first several minutes and calculates the time between frames from the video duration.

TEST VERSION!

Make a copy before overwrite the original files!

 

[greybox]

I could not test your V3 (I am getting black home screen starting with version V2a)

I noticed Time offset parameter is listed without indication what this is (seconds, minutes, hours). Like I suggested earlier, it wold be nice to add that information.

I understand time between frames is not listed because it is calculated. How do you calculate it, what is the algorithm?

 

[Sebastiii]

@regeszter
I have black screen too on V2a
I will try V3 later but if i'm not wrong, you need to use : 'DeployToolUnPacker-x64.nsi' from '\Tools\InstallationScripts' for x64 OS and 'DeployToolUnPacker.nsi' for 32 one.

Maybe you already use it but it will make dll compatible for 1.4.0 actually yours is tagged @ 1.4.0.2 / 1.4.0.2-g46c7aa9

Can you supply your modified files (*.cs) with your zip ?

Thanks

 

[regeszter]

Hi,

sorry for the mistake regards windowsplugins.dll

Try this version!

The calculation method is the following:

if (preGapSec > Duration)
 
	  {
		preGapSec = Duration - 5;
	  }
 
TimeBetweenFrames = Convert.ToInt16((Duration - preGapSec) / (PreviewColumns * PreviewRows + 1));

If to be a final version, I will provide the source code of course (patch or cs?).


Thanks!

 

[Sebastiii]

Thanks

I prefer the .cs because with your path, it can't be apply (i mean your last one is a diff between 2 files and i can't apply it, i need to do it manually)

Seb

 

[regeszter]

Hi,

there is a performance issue to seeking the big files (longer than 30 mins) in my system. I think, not a good idea to seek the full file for thumbs. What about to limit the duration value?