[fixed] 4k HEVC DXVA2 not playing correctly in MP2 (2 Viewers)

[morpheus_xx]

I also pushed some changes that seem to fix the NetStreamSourceFilter memory leaks. I can now play all test files.
Please check if you think the reasons (read commits) I found are plausible.
Remember to uncomment the NetStreamSourceFilter bypass if you want to test it.

Yes, that are exactly the changes I would have done as next. Thanks Will try more with new sample file.

Alright, test file uploaded

Where did you upload it?

 

[JSchuricht]

Where did you upload it?

I guess it would help if I posted a link.

https://tinyurl.com/yd95gnj6

 

[morpheus_xx]

Here my results with Intel HD530 and LAV 0.72 (the chip is not capable of 4k hardware decoding)

When LAV splitter enabled HEVC as supported HW codec, DXVA2 (native) is chosen in MP2. Playback starts but due to missing HW support there is only a black screen.

Now I tried inside GraphStudio, there I got very distorted, pixeled results.

Last try was to disable HEVC inside LAV video decoder configuration, and as result the test file played without any issues.

PS: from which movie the sample is taken?

 

[henso]

Here my results

I tried with my Nvidia card and first playback works fine but after some playbacks it fails with D3DERR_OUTOFVIDEOMEMORY. Seems we are still missing some cleanup even with the bypass.

PS: from which movie the sample is taken?

Looks like Jurassic World 2.

 

[HTPCSourcer]

but after some playbacks it fails with D3DERR_OUTOFVIDEOMEMORY. Seems we are still missing some cleanup even with the bypass.

Where do we go from here?

 

[henso]

Where do we go from here?

You better ask @morpheus_xx. I’m not really that experienced with filters and graphs.

 

[morpheus_xx]

Where do we go from here?

We fixed the graph release, so that every filter and the graphbuilder itself is released at the right time and order. So all the warning messages about remaining references are gone.

Additionally we implemented IDisposable pattern to our DotNetStreamSource, which was not yet correctly released when we wanted it to.

The OutOfMemory exceptions are another part. I can't reproduce them here, but henso can. This could mean that different hardware/software/drivers could make a differerence. I am not sure if this is related to graph and filters at all. So there is not clear answer...

 

[HTPCSourcer]

We fixed the graph release

To which version does this apply? The OP observes the issues also in MP 2.2.

I am also uncertain about the LAV filter settings as you deactivated HEVC before being able to play the file.

 

[morpheus_xx]

To which version does this apply? The OP observes the issues also in MP 2.2.

Yes, the changes are part of 2.2.1 branch only.

I am also uncertain about the LAV filter settings as you deactivated HEVC before being able to play the file.

There is wide range of combinations: Codec, color bit depth, hardware support, hardware decode mode (DXVA/CB, DX11). I.e. I needed to deactivate HEVC for 10bit samples, but other HEVC videos worked fine.

 

[HTPCSourcer]

the changes are part of 2.2.1 branch only

Should @JSchuricht be given a link to the latest build for testing purposes?

I needed to deactivate HEVC for 10bit samples,

Wouldn't that suggest an issue in LAV?