[Bug] Mantis 3731: "Checkmark control is not scaled" is not completely fixed (1 Viewer)

[Lbr_Lion]

Hi,

It looks like that mantis 3731 is not completely fixed: The "Checkmark" control is scaled now, but the "Checkbutton" control not yet:

1280x720

1920x1080

Cheers,

 

[ajp8164]

Looking at the implementation I can see why it doesn't work. Definitely a bug!

 

[infinite.loop]

Looking at the implementation I can see why it doesn't work. Definitely a bug!

I changed the thread prefix for you.

 

[ajp8164]

@Lbr_Lion - Please post steps to reproduce what you are seeing; I can't seem to reproduce. Thanks!

 

[Lbr_Lion]

Hi,

I don't know or you did test it in window mode, but it looks like it is less clear in this mode.

I can reproduce it in fullscreen mode by the following steps.

- (Close MediaPortal)
- Set desktop size to 720p (1280x720)
- Start MediaPortal in fullscreen mode
- Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring
- Close MediaPortal
- Set desktop size to 1080p (1920x1080)
- Start MediaPortal in fullscreen mode
- Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring

Via these steps I can clearly see the difference in size and location of the checkmark. (Also in Default Wide skin)

 

[elliottmc]

Have we checked in the code that the fix was correctly included? Mistakes do happen.

 

[ajp8164]

Hi,

I don't know or you did test it in window mode, but it looks like it is less clear in this mode.

I can reproduce it in fullscreen mode by the following steps.

- (Close MediaPortal)
- Set desktop size to 720p (1280x720)
- Start MediaPortal in fullscreen mode
- Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring
- Close MediaPortal
- Set desktop size to 1080p (1920x1080)
- Start MediaPortal in fullscreen mode
- Go to Settings-->TV and check the size and location of the checkmarks for Genre colouring

Via these steps I can clearly see the difference in size and location of the checkmark. (Also in Default Wide skin)

Yep, verified. Now we need to figure out what's wrong...

 

[ajp8164]

Done. Fix is applied to branch BUG-3731-Checkmark_scaling. Need @Lbr_Lion to test..

 

[Lbr_Lion]

Thanks!

Build a new version based on the branch and did the same steps as mentioned in the previous post and everything works fine now.

PS. I noticed also that the HD logo in the TV Guide is not scaled. Can you have a look to this also?

 

[elliottmc]

Since this is a one-line fix that is confirmed to fix the issue, I suggest that Andy sends a PM to a development team manager to approve merge to master.

Mark