Pandora Plugin not advancing to the next song (23 Viewers)

hwahrmann

Development Group
  • Team MediaPortal
  • September 15, 2004
    4,630
    2,462
    Vienna, Austria
    Home Country
    Austria Austria
    There shouldn't be anything like cross-fade in this case.
    BASS is notified that a song ended and will fire a respective message, which is consumed by the Pandora Plugin, which then starts playback of the next song.

    So from our point there is no skipping.

    maybe the logs show something?
     

    Cam

    Portal Pro
    February 28, 2012
    360
    97
    63
    Georgia
    Home Country
    United States of America United States of America
    Here are some logs and a Music setting pic
     

    Attachments

    • Pandora 1.jpg
      Pandora 1.jpg
      281.7 KB

    mm1352000

    Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,544
    8,236
    Home Country
    New Zealand New Zealand
    The plugin detects skipping based on this condition:
    https://github.com/kwill1429/pandor...rce/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L172
    Code:
    bool isSkip = PlayingRadio && !ignoreSkip;

    ignoreSkip has and is always going to be false in this case, so the change in behaviour seems most likely to be as a result of a change in the "PlayingRadio" part of the condition. The code for that property is:
    https://github.com/kwill1429/pandor...urce/MediaPortalPlugin/GUI/MusicBoxGUI.cs#L23
    Code:
    private bool PlayingRadio { get { return g_Player.Playing && Core.MusicBox.CurrentSong != null && g_Player.CurrentFile == Core.MusicBox.CurrentSong.AudioURL; } }

    I would guess that the issue is that g_Player.Playing is still true and/or g_Player.CurrentFile is not set null before OnPlaybackEnded() is invoked... and it may not have been that way in the past.
     

    Cam

    Portal Pro
    February 28, 2012
    360
    97
    63
    Georgia
    Home Country
    United States of America United States of America
    Weird?:unsure:
    On another computer it is working just fine, up to about 6 in a row, want logs for this computer?

    Well it stoppped after about 8
     
    Last edited:

    Cam

    Portal Pro
    February 28, 2012
    360
    97
    63
    Georgia
    Home Country
    United States of America United States of America
    you are very polite![DOUBLEPOST=1463872957][/DOUBLEPOST]Hold your horses wrong logs sorry, here are the current ones
     

    Attachments

    • Pandora 2.jpg
      Pandora 2.jpg
      427.7 KB

    Cam

    Portal Pro
    February 28, 2012
    360
    97
    63
    Georgia
    Home Country
    United States of America United States of America
    Do you think this can be fixed?
    This plug-in is a great addition to mediaportal for music, the sound quality is excellent.

    Thanks
     

    mm1352000

    Retired Team Member
  • Premium Supporter
  • September 1, 2008
    21,544
    8,236
    Home Country
    New Zealand New Zealand
    As usual, I'm not able to fix this. I can identify the probable source of issues in the code sometimes, but my knowledge of how MediaPortal's player - and in particular: the music player - should work is non-existent. @hwahrmann is the person you need.
     

    Users who are viewing this thread

    Similar threads

    If you’re planning to submit a pull request, let’s go through the list of issues and their solutions. I or someone from the team will create a Jira ticket, and for each ticket, you’ll make the changes and submit a pull request. This will be transparent and straightforward.
    If you’re planning to submit a pull request, let’s go through the list of issues and their solutions. I or someone from the team...
    I'm very glad to see that mediaportal 1 is on github, where ordinary devs with github accounts can make contributions. Please can...
    Replies
    7
    Views
    1K
    I don't know about MP2 but as you said you tried MP1 too, how is the MP music config ? MP(1) will only use LAV if you select "Internal DirectShow player" as music output, but then you lose gapless playback. If you you don't have multichannel music you can choose WASAPI as the output and set the number of speakers to stereo. I have...
    I don't know about MP2 but as you said you tried MP1 too, how is the MP music config ? MP(1) will only use LAV if you select...
    Not sure if this a a bug/config/settings problem. I am running a media portal 2.5 server with 2.41 client but it seems I get the...
    Replies
    1
    Views
    659
    As easy as that ;). Restarted HTPC and 'out of memory' errors have disappeared, thank you!
    As easy as that ;). Restarted HTPC and 'out of memory' errors have disappeared, thank you!
    Just installed the MediaPortal 1.37 Pre-Release. Client takes a long time to start up because it is looking for the...
    Replies
    4
    Views
    2K
    I used to use the grabber but a few years back it disappeared on FreeSat DVBS. That is when I changed to EPG Collector. The extra benefit is that it collects from the Sky platform so it will give EPG for all the FreeSat channels plus the unencrypted movie channels on the Sky platform. It also allows me to pick the channels dedicated...
    I used to use the grabber but a few years back it disappeared on FreeSat DVBS. That is when I changed to EPG Collector. The extra...
    Hi everyone, I hope you are all well My Mum's Mediaportal lost it's marbles thanks to Microsoft update, (even though I had update...
    Replies
    2
    Views
    2K
    MP1 supports TVE 3 MP2 supports TVE 3, TVE 3.5 (unstable), TV Mosaic - I think so.
    MP1 supports TVE 3 MP2 supports TVE 3, TVE 3.5 (unstable), TV Mosaic - I think so.
    I am a long-time user of MediaPortal to watch TV. I use the Media Portal TV Server as a backend, and Kodi (previously known as...
    Replies
    19
    Views
    8K
    Top Bottom