Pandora Plugin not advancing to the next song (2 Viewers)

[mm1352000]

@hwahrmann
One thing I notice that I think is a bit odd...
[collapse]
[2015-07-06 20:36:39,379] [Log ] [BASS X-Fade] [DEBUG] - BASS: X-Fading out stream http://audio-ch1-t1-1-v4v6.pandora.com/access/568503232955461445.mp4?version=4&lid=338947483&token=G0/BLuaqgInSMGXZpANjh5kc3EmYwY+r4RK0gShlj3dWAazmuP5wM9EdRwJGzVMtsJt69fCV9AMpqdwjfhHaMmapNLOrxLRxjly6PaPCTQIWFb3bmWLMSQd5yV/tVJNBy6rwrC9bBRfQVeui14UUcUQ6Z1c/t8A8LFwwlqx7z1sxmWIEZXAGjScOOmJ6AfNvPhaQeaRLM5Rag5VgOYQTbCukhP9IOSnB4Xa620VROeHnTtAevEvsT1Vb6qyEN4qCTBOKF5+nWYZs6EroaJ8jgv5FrHO34JDtV+S8/jScIDDA/mPqN87eDlrDya5z1kuko5J2w+364jde6SLyCh6wq6rD2He4nhDT4/us8JcJ5YeN8AZ3ElHw9wT11LV10FRY
[2015-07-06 20:36:39,381] [Log ] [21 ] [DEBUG] - BASS: End of Song http://audio-ch1-t1-1-v4v6.pandora.com/access/568503232955461445.mp4?version=4&lid=338947483&token=G0/BLuaqgInSMGXZpANjh5kc3EmYwY+r4RK0gShlj3dWAazmuP5wM9EdRwJGzVMtsJt69fCV9AMpqdwjfhHaMmapNLOrxLRxjly6PaPCTQIWFb3bmWLMSQd5yV/tVJNBy6rwrC9bBRfQVeui14UUcUQ6Z1c/t8A8LFwwlqx7z1sxmWIEZXAGjScOOmJ6AfNvPhaQeaRLM5Rag5VgOYQTbCukhP9IOSnB4Xa620VROeHnTtAevEvsT1Vb6qyEN4qCTBOKF5+nWYZs6EroaJ8jgv5FrHO34JDtV+S8/jScIDDA/mPqN87eDlrDya5z1kuko5J2w+364jde6SLyCh6wq6rD2He4nhDT4/us8JcJ5YeN8AZ3ElHw9wT11LV10FRY
[2015-07-06 20:36:43,382] [Log ] [BASS X-FadeEnded] [DEBUG] - BASS: Fading of stream finished.
[2015-07-06 20:36:43,858] [Log ] [21 ] [DEBUG] - BASS: Disposing Music Stream http://audio-ch1-t1-1-v4v6.pandora.com/access/568503232955461445.mp4?version=4&lid=338947483&token=G0/BLuaqgInSMGXZpANjh5kc3EmYwY+r4RK0gShlj3dWAazmuP5wM9EdRwJGzVMtsJt69fCV9AMpqdwjfhHaMmapNLOrxLRxjly6PaPCTQIWFb3bmWLMSQd5yV/tVJNBy6rwrC9bBRfQVeui14UUcUQ6Z1c/t8A8LFwwlqx7z1sxmWIEZXAGjScOOmJ6AfNvPhaQeaRLM5Rag5VgOYQTbCukhP9IOSnB4Xa620VROeHnTtAevEvsT1Vb6qyEN4qCTBOKF5+nWYZs6EroaJ8jgv5FrHO34JDtV+S8/jScIDDA/mPqN87eDlrDya5z1kuko5J2w+364jde6SLyCh6wq6rD2He4nhDT4/us8JcJ5YeN8AZ3ElHw9wT11LV10FRY
']
'][/collapse]

...then later...

[2015-07-06 20:37:19,319] [Log ] [MPMain ] [DEBUG] - g_Player.doStop() keepTimeShifting = False keepExclusiveModeOn = False
[2015-07-06 20:37:19,319] [Log ] [MPMain ] [INFO ] - g_Player.OnStopped()

So, it looks like BASS notices the end of the stream is reached, but the player doesn't realise it has stopped (???). Key point is that there is no g_Player.OnEnded() notification. From the code, I think the Pandora plugin may rely on that notification in order to start the next song.

Any thoughts?

 

[Cam]

Oh Ok,
The reason I didn't mention it is because it was the 1st time it happen that I know of and you know computers are, sometimes things don't flow like they should ..... do a reboot all is well until the next time.

 

[mm1352000]

@hwahrmann
Did you see this question?

 

[hwahrmann]

No, haven't seen that.
i guess you are right that Pandora needs to get a player ended events.

i just wonder how the Bassd player was able to detect end of stream on a http resource.
This should never happen.
I never used this plugin. do we need credentials for running it?

 

[mm1352000]

do we need credentials for running it?

Unfortunately yes I think so.

 

[mm1352000]

In case it helps, you can see the relevant code here:
http://pandora-musicbox.googlecode.com/svn/trunk/Source/MediaPortalPlugin/GUI/MusicBoxGUI.cs

private void OnPlayBackEnded(g_Player.MediaType type, string filename) {
  try {
    if (!initialized || handlingEvent) return;
    handlingEvent = true;

    if (Core.MusicBox.CurrentSong != null && filename == Core.MusicBox.CurrentSong.AudioURL) {
      logger.Debug("Playback ended for current Pandora song.");
      setWorkingAnimationStatus(true);
      PlayNextTrack();
      setWorkingAnimationStatus(false);
    }
  }
  catch (Exception ex) {
    GracefullyFail(ex);
  }
  finally {
    handlingEvent = false;
  }
}

And in Init():

g_Player.PlayBackEnded += new g_Player.EndedHandler(OnPlayBackEnded);

So, the plugin is triggered to play the next track when the current one finishes.

The log shows that this function is being called by BASS:
https://github.com/MediaPortal/Medi...tal/Core/MusicPlayer/BASS/MixerStream.cs#L845

That function notifies the audio engine to start crossfading:
https://github.com/MediaPortal/Medi...Core/MusicPlayer/BASS/BassAudioEngine.cs#L533

There should not be any next song queued so I don't understand why the log says "BASS: Fading of stream finished." instead of the expected "BASS: Reached end of playlist.".

 

[Cam]

I can hit the next or skip button on the remote and it will advance to the next song

 

[hwahrmann]

I guess the above code should also listening on Crossfade Event.
i can look into it after my vacation.

 

[mm1352000]

I guess the above code should also listening on Crossfade Event.

Maybe. However, Cam said that the problem happens even when cross-fading is disabled.
https://forum.team-mediaportal.com/...vancing-to-the-next-song.131005/#post-1141985

Thanks for your willingness to investigate.

 

[Cam]

Thanks guys for looking into this.