RED DOT recording state doesn't appear in video fullscreen playing (1 Viewer)

[framug]

I just look at older (last week) NCIS Los Angeles serie (one of my prefered one).
Where new episodes are recording right now.
Looking at OSD with this changes is just happiness.
I will not put screens since the white part problem.
I hope, you will definitively integrate it in MP 1.22 (as far as I can see, it's not in "master" branch)

 

[CyberSimian]

First, apologies to @ajs. The sample code that I suggested be placed in "BasicHome.xml" does work correctly. Looking at it this morning, I see that what I tested was the visibility condition "Player.Recording". As there is some doubt about that visibility condition working, let us put that aside for now and consider only "#TV.Record.Active".

This is what testing this morning has shown:

(1) If I start MP with a recording active, "#TV.Record.Active" displays as the value "true" on the "Basic Home" panel.

(2) If I start MP with no recording active, "#TV.Record.Active" displays as the null string. I believe that this is the incorrect value -- it should display as the string "false".

I would suspect that (2) arises because "#TV.Record.Active" is being initialised to the null string (zero length string). The null string is an appropriate initial value for many built-in skin variables, but not in this case. The initial value in this case should be the string "false".

This area is so complicated that we need to fix one bug at a time. Testing with multiple bugs present just leads to confusion. Yes, I think that there are other bugs present, but we will get to those when this initial-value bug has been fixed.

@ajs If you agree with the change to the initial value, please make that change and create another Team-City build for me to test. Thank you.

-- from CyberSimian in the UK

 

[ajs]

All MP initial properties value - empty string. Its by design
it does not affect anything. You compare property value with true.
empty string not equal true
null not equal true
false not equal true
only true equal true

--
WBR, ajs

 

[framug]

Guys, finally latest screenshoot on my side for all this stuff. (be afraid with theses blank screens)
What about Myvideos (played since some hours) when one or more records are "in the place" ?
In my case at this time, recording (for french, I'm sure sebastii or azzuro will understand ) :

TF1 : "C'est canteloup"
Cstar : "Shooter tireur d'élite"
In real time recording and other play(s) at the same time.
Then, if it's not a "real time" great improvment with little code change/add, I don't know what it is.
If you are skilled enough to do more, please, do it...
And of course, I don't force you to finally integrate this in future release...
Hope you understand the language difference, I don't want to hurt someone anymore...

 

[azzuro]

OFF TOPIC
Hey Framug
Comment va ?
OFF TOPIC

 

[ajs]

(be afraid with theses blank screens

Thanks! No whte space on screenshot ...

Hope you understand the language difference

Did not quite understand what the problem is Or is it not?

 

[framug]

Did not quite understand what the problem is Or is it not?

No problem, just I didn't want to be misinterpreted regarding an older post from another skilled dev.
I'm not the owner of MP, of course
@azzuro : I'm fine, thanks, I hope you too and hope you try, if you have time, this new feature.

 

[framug]

Hi there,

Finally, we can say that the 1.22 release was a great release improvment, isnt'it ?
Serioulsy, for this changes, thanks for all devs but, the most parts would be credit to skinner(s) who made it possible (a lot of works) !!!



Some personnal remarks :
There is a long delay between record really active and display for (could it be improved ?)
May be because of an external plugin ?
For the future, in hope signal and level strength would be in a personal way (I show you the way in a specific C# code, if users wants their own way, it is possible by collaborative way)...
The ball is in your camp, if you want to keep it, please, catch it.

 

[CyberSimian]

There is a long delay between record really active and display for

Yes, I have noticed this too. If I am on an MP panel when a recording starts, the red dot appears first, but the pop-up telling me the channel name and title appears several seconds later. And the same happens when the recording finishes.

I don't know the cause, but it may be related to the nature of the implementation. Possibly the MP client polls TV Server, but to avoid consuming too much of the CPU, the client polls only once every (say) 5 seconds. But this is just a guess!

-- from CyberSimian in the UK

 

[azzuro]

May be because of an external plugin ?
For the future, in hope signal and level strength would be in a personal way (I show you the way in a specific C# code, if users wants their own way, it is possible by collaborative way)...
The ball is in your camp, if you want to keep it, please, catch it

catched,
As you know, better to share, we missing dev for improvement.