The Future of MyFilms? (2 Viewers)

[Dadeo]

Hi Guzzi - I finally had some time to test (in 1.1.2) and everything seems really good. Performance even seems better to me, although that could be 1.1.2 as well.

I have not even managed to test all the new features yet! But everything I tried worked perfectly - Nice work!

The only thing I still find a bit odd is that when I press F9 or Info/More key on remote, it opens the Menu, not a context menu or dialog as is normal in MP. But not a big deal.

If I had one request for 5.0 - can you make the Supplmentary View display the view name and not the value? For example, for my Unwatched view, it displays "[False]" rather than 'Unwatched" which just confuses everyone who sees it! Better yet would be a standard Unwatched or New view (configurable for diff catalogs or whether user uses Checked field or not)

A nice icon for MyFilms in Config would be great (makes it easier to find when you have a lot of plugins)! In fact, a new icon for MyFilms could be good as it is not just ANT anymore. You can use such a logo/icon in many places so users become very familiar with MyFilms.

Let me know when you are ready to add some Docs to the new Wiki. I will gladly help. I think it will open up MyFilms to many new users who already seem to be using the Wiki more than the forums. You would be one of the first extensions to have some nice Docs there

Is it time to add 4.9.2.3 to the MP Downloads Repository? It really feels missing there!

Many thanks for all your work!

 

[Guzzi]

AW: Re: The Future of MyFilms?

Hi Guzzi - I finally had some time to test (in 1.1.2) and everything seems really good. Performance even seems better to me, although that could be 1.1.2 as well.

I have not even managed to test all the new features yet! But everything I tried worked perfectly - Nice work!

The only thing I still find a bit odd is that when I press F9 or Info/More key on remote, it opens the Menu, not a context menu or dialog as is normal in MP. But not a big deal.

You're talking about detailsview, right? I could see if I map the contextmenu in details directly to the updatemenu?

If I had one request for 5.0 - can you make the Supplmentary View display the view name and not the value? For example, for my Unwatched view, it displays "[False]" rather than 'Unwatched" which just confuses everyone who sees it! Better yet would be a standard Unwatched or New view (configurable for diff catalogs or whether user uses Checked field or not)

Well, using "name" instead "value" doestn't make sense, because you want to see e.g. resolutionvalue, actorname, etc.

What you already have is let watched movies have the "watchedcolor" in the skin.

Imho there are two possibilities regarding the "watched-stuff":
1.) Have a separate "hardcoded" view, that translates the "true/false" of the field to the users language (e.g. "watched/unwatched")
2.) Implement the watched-status as a global "overlayfilter" - so you could just switch it on or off and combine it with all views you have available.
I personally think "2" is a better and even more flexible solution - I have already implemented such a global overlayfilter for the rating in 5.1 alpha, there you can define in options a minimum rating and if you want this filter on/off and it will then be active in all views, presenting you just the movies matching this condition - same could be done as "show only unwatched movies" global option...

I could do "1" with current 4.8.x version if you think it should - but with "2" I'd prefer to leave this for 5.1, because this overlayfilter is already implemented there...

A nice icon for MyFilms in Config would be great (makes it easier to find when you have a lot of plugins)! In fact, a new icon for MyFilms could be good as it is not just ANT anymore. You can use such a logo/icon in many places so users become very familiar with MyFilms.

Have changed icon in 5.1 already - could backport this to 4.8.x ...

Let me know when you are ready to add some Docs to the new Wiki. I will gladly help. I think it will open up MyFilms to many new users who already seem to be using the Wiki more than the forums. You would be one of the first extensions to have some nice Docs there

Yes, docs are quite outdated ... I know ... and a plugin like MyFilms is almost unusable without a good documentation.
I would very much appreciate any help and maybe some info what's the best way to update.

Is it time to add 4.9.2.3 to the MP Downloads Repository? It really feels missing there!

Actually I was waiting for feedback from helios as he said he would do some testing and I have also PMed Catavolt, because he mentioned in another thread, that there are issues in 4.9.x that holds him from supporting it in his skins (he still stays on 4.8c) - so I don't want to publish the version, before it's confirmed to work - as without skinsupport it's quite unusable ;-)

 

[Dadeo]

Re: AW: Re: The Future of MyFilms?

You're talking about detailsview, right? I could see if I map the contextmenu in details directly to the updatemenu?

Nope, when I press info or F9 in any view it goes to menu with Search highlighted. Don't forget I am not using AMC Updater. What am I supposed to see when I press Info key?

Imho there are two possibilities regarding the "watched-stuff":
1.) Have a separate "hardcoded" view, that translates the "true/false" of the field to the users language (e.g. "watched/unwatched")
2.) Implement the watched-status as a global "overlayfilter" - so you could just switch it on or off and combine it with all views you have available.
I personally think "2" is a better and even more flexible solution - I have already implemented such a global overlayfilter for the rating in 5.1 alpha, there you can define in options a minimum rating and if you want this filter on/off and it will then be active in all views, presenting you just the movies matching this condition - same could be done as "show only unwatched movies" global option...

I could do "1" with current 4.8.x version if you think it should - but with "2" I'd prefer to leave this for 5.1, because this overlayfilter is already implemented there...

Yes and Yes - you should know better than to give us options Seriously though, I have been living with it for years now, so it is hardly critical. Both options sound great. If you want to wait until 5.1 fine with me.

Yes, docs are quite outdated ... I know ... and a plugin like MyFilms is almost unusable without a good documentation.
I would very much appreciate any help and maybe some info what's the best way to update.

Ok, first login to new wiki using your forum username and pw - then I can give you edit permissions. I transferred the 'old' wiki docs for MyFilms So we can start with that. When you are ready just 'hit' me in IRC and we can work on it.

Actually I was waiting for feedback from helios as he said he would do some testing and I have also PMed Catavolt, because he mentioned in another thread, that there are issues in 4.9.x that holds him from supporting it in his skins (he still stays on 4.8c) - so I don't want to publish the version, before it's confirmed to work - as without skinsupport it's quite unusable ;-)

Do you have a link for that thread? I have no issues in aMPed. But maybe I have not tried to miplement everything yet. I know the most confusing part for me was sorting out the Title vs OTitle for users. Since in the skin some users want one as the main title and some want the other. They can set it in MyFilms Config for the selected item (in lists etc), but the skin properties for Title and OTitle don't change with that setting. So I have to get some users to test the 4.9.2.3 to be sure.

Any thoughts of changing the plugin name to Films? We are trying to slowly get rid of the My option since it just screws up searching and sorting everywhere. Case in point - if a user does not remember it is one word and searches for My Films instead of MyFilms - guess what happens? (Just take a look at this thread vs Sub forum title )

 

[Guzzi]

AW: Re: AW: Re: The Future of MyFilms?

You're talking about detailsview, right? I could see if I map the contextmenu in details directly to the updatemenu?

Nope, when I press info or F9 in any view it goes to menu with Search highlighted. Don't forget I am not using AMC Updater. What am I supposed to see when I press Info key?

ok, you're right - my mistake - I changed it in 5.1 already to get true contextmenu on infobutton in mainview - just checked with 4.8.x and can confirm you're right...

Imho there are two possibilities regarding the "watched-stuff":
1.) Have a separate "hardcoded" view, that translates the "true/false" of the field to the users language (e.g. "watched/unwatched")
2.) Implement the watched-status as a global "overlayfilter" - so you could just switch it on or off and combine it with all views you have available.
I personally think "2" is a better and even more flexible solution - I have already implemented such a global overlayfilter for the rating in 5.1 alpha, there you can define in options a minimum rating and if you want this filter on/off and it will then be active in all views, presenting you just the movies matching this condition - same could be done as "show only unwatched movies" global option...

I could do "1" with current 4.8.x version if you think it should - but with "2" I'd prefer to leave this for 5.1, because this overlayfilter is already implemented there...

Yes and Yes - you should know better than to give us options Seriously though, I have been living with it for years now, so it is hardly critical. Both options sound great. If you want to wait until 5.1 fine with me.

Yes, docs are quite outdated ... I know ... and a plugin like MyFilms is almost unusable without a good documentation.
I would very much appreciate any help and maybe some info what's the best way to update.

Ok, first login to new wiki using your forum username and pw - then I can give you edit permissions. I transferred the 'old' wiki docs for MyFilms So we can start with that. When you are ready just 'hit' me in IRC and we can work on it.

Ok, have logged in, so my name should be registered now...

Actually I was waiting for feedback from helios as he said he would do some testing and I have also PMed Catavolt, because he mentioned in another thread, that there are issues in 4.9.x that holds him from supporting it in his skins (he still stays on 4.8c) - so I don't want to publish the version, before it's confirmed to work - as without skinsupport it's quite unusable ;-)

Do you have a link for that thread?

-> https://forum.team-mediaportal.com/...purevision-skins-46682/index2.html#post664628

I have no issues in aMPed. But maybe I have not tried to miplement everything yet. I know the most confusing part for me was sorting out the Title vs OTitle for users. Since in the skin some users want one as the main title and some want the other. They can set it in MyFilms Config for the selected item (in lists etc), but the skin properties for Title and OTitle don't change with that setting.

Actually Zebons removed the former titlehandling when he exposed all properties via "#myfilms.xxxx".
I could readd properties for the userdefined titlehandling to help skinners, like:
#myfilms.mastertitle
#myfilms.secondarytitle
and match those to the settings the user made in configuration.
What do you think?

So I have to get some users to test the 4.9.2.3 to be sure.

Any thoughts of changing the plugin name to Films? We are trying to slowly get rid of the My option since it just screws up searching and sorting everywhere. Case in point - if a user does not remember it is one word and searches for My Films instead of MyFilms - guess what happens? (Just take a look at this thread vs Sub forum title )

I have no problem with that - I use other title anyway via the configuration ;-) ...

 

[Guzzi]

AW: The Future of MyFilms?

Hi Dadeo,

find attached updated dll only that includes:
- fix for contextmenu - should now open contextmenu in main and detailscreen
- added "searchrelated persons" and "searchrelated properties" to main contextmenu
- added #myfilms.mastertitle and #myfilms.secondarytitle as properties - it should match the configured values of master and secondary in config - but I didn't test it myself - so let me know if this helps or if I should remove it

I did not implement the handling for watched/unwatched, cause I think above mentioned solution "2" is really much better - but will do this in 5.x later.

 

[Dadeo]

Re: AW: Re: AW: Re: The Future of MyFilms?

Ok, have logged in, so my name should be registered now...

Yep, gave you contributor status - now you get to read the endless Help docs on using the new Wiki!

-> https://forum.team-mediaportal.com/...purevision-skins-46682/index2.html#post664628

Well that post is over two months old and several versions ago. I am not sure catavolt has had time to test the latest version yet. But imo the B3 skin files you provided do not produce any errors in 1.1.2. It's a bit of chicken and egg. I am not sure many skinners realize there is a working version now. Hey users can just use aMPed AFAIK you now have moderator rights on all My Films forum threads now. Didn't anyone tell you? So you can post the mpe1 file in the first post of the thread rekenaar started for latest version.

Actually Zebons removed the former titlehandling when he exposed all properties via "#myfilms.xxxx".
I could readd properties for the userdefined titlehandling to help skinners, like:
#myfilms.mastertitle
#myfilms.secondarytitle
and match those to the settings the user made in configuration.
What do you think?

Now you are confusing me again. In MesFilms.xml I use #selecteditem so it is no problem. But in MesFilmsDetail.xml you have to use #myfilms.originaltitle and #myfilms.translatedtitle since it is a separate window with no listcontrol so no #selecteditem . Now IIRC, in My Films config a user can select the Title Order. Many choose Translated Title since they are not native English speakers.

However, imo this is problematic because IMDB often creates very long Translated Titles like: "Avatar: An IMAX 3D Experience (USA) (IMAX version), James Cameron's Avatar (International: English title) (promotional title), Project 880 (USA) (working title)" which MP will not accept. Thus I get an error log (attached) when I use Translated Title as the main title since it is likely looking for fanart and images matching that ridiculous title.

If I use Original Title as the Main Title in Title Sort Order, then no title displays on Details view using your B3 skin files. (see first screenshot) In checking the skin files, I see original title is control ID 26 and translated Title is control ID 25. If I reverse them then I get a Title, using Original Title, as in the second screenshot.
And I still get both titles when using Translated Title as the Main Title, as in the third screenshot. However, no fanart since it does not match.

So in conclusion YES - a way to make the titles match what the user defines would be great. However, it seems to me that the fanart matching always has to be on the English title or you won't find much fanart. How the hell you are supposed to know if the English title is in Original Title or Translated title beats me since users can use many different scripts in the ANT catalog to import data.

Just a suggestion - but that black text color is really almost unreadable for me.

I have no problem with that [changing title to Films ]- I use other title anyway via the configuration ;-) ...

Me too!

 

[rekenaar]

Re: AW: Re: AW: Re: The Future of MyFilms?

AFAIK you now have moderator rights on all My Films forum threads now. Didn't anyone tell you?

I did

 

[Dadeo]

OK I missed your last post Guzzi with the test zip. But I suspect many of my comments/issues re the titles still apply?

 

[Guzzi]

AW: Re: The Future of MyFilms?

OK I missed your last post Guzzi with the test zip. But I suspect many of my comments/issues re the titles still apply?

I will have to check the code again - you have confused me too ;-)

My suggestion to expose #myfilms.mastertitle and #myfilms.secondarytitle was meant to make it possible to use those properties in detailsscreen and let the user configure, what title to display as master/secondary himself, because most users won't be able to swap them by themselves in the skinfile.
But as you reported, there seems to be a problem with the visibility control, will have to check.

I remember, I made a fix for the fanarttitlehandling (it was always using translatedtitle regardless of setting of mastertitle) - but this of course doestn't help when in the scenario you described - but for normal usage, when user configures translated title as mastertitle most probably the translatedtitles are of "good quality" ... otherwise it doestn't make sense anyway, right!?

Re posting version: I know, just wanted to first get some testresults before posting on stickypage ;-)

Re b3/b3wide: those skins are unchanged since zebons created/modified them ... I know, they would need some "beautifying" ;-) - at least before posting a final version ...

Will go to bed now and have a look at all those "titlemappingstuff" tomorrow ...

 

[Dadeo]

Hi Guzzi - hope you had a good rest

I tested the zip dll of 4.9.2.4 - context menu is good. Search is great. One minor issue, when you search, the search actually respects the current view selected. So in my case, when I search on Edward Norton for example, in my Unwatched view, it only retrieves 1 movie which is correct. However, on the context menu it shows Edward Norton as Producer (1) Actor (6) - 6 is the correct number of total movies in my db in which he is listed as an actor. At first I was confused by the number 6. Now I understand it, it may be quite useful. However the ideal would be "1 (6)" or "1 of 6" tho I am not sure that is much clearer or necessary as long as you explain what the count means somewhere.

I did not test the new #myfilms.mastertitle and #myfilms.secondarytitle properties yet. However, I do like those names a LOT better. I am not really sure what to suggest. I only know English movies and IMDB script and how that works. What script do you use and how does it enter the data for you? Keep in mind that other catalogs likely use a diff name for that Orignal Title field. That is why I prefer your name of master title. Original Title was always odd imo.

Of course it is complicated, because IMDB lists movie titles according to the country where they were produced - hence the name Original Title I presume One case = Io sono l'amore (2009) from Italy ("I am Love" in English). First thing I do is switch the titles in ANT so the Original Title is in English or I can never remember the name of the movie! So I did a few tests and it seems that most ANT scripts do put the English title in Original Title (if the movie is English), even when using foreign language scripts.

The problematic one seems to be the English IMDB script which, as I indicated previously, often displays a ridiculously long list of alternate titles. However, you cannot afford to disable Translated Title entirely, because in the case of a foreign film the English title displays in the Translated Title field.

Usually TMdb does a good job of redirecting foreign language titles to the correct movie page, at least in all the cases I tested.

Conclusion - I think matching fanart on master (original) title is usually fine. And display in Main view is fine. In Details View imo Title Order should actually switch the titles as you suggested - i.e. if Translated Title is selected in Config, then it becomes Master Title. Thus in the skin you simply put the master and secondary titles to display correctly and the user chooses which title displays as master title. However fanart (and posters?) still should always match on original title I think. If anyone knows cases where this does not work, I hope they speak up!