Help with samples filter RegEx (1 Viewer)

[kiwijunglist]

J:\MOVIES [HD]\Escobar Paradise Lost (2014) - tt2515030\Extras\Test File.mkv

if I create like above, then I restart importer it tries to match the test file.mkv to the movie "Extras (2005)"

 

[ajs]

May be:
((sample)s?)|(\\((extra)|(trailer))s?\\)

 

[ajs]

if I create like above, then I restart importer it tries to match the test file.mkv to the movie "Extras (2005)"

May be - Using Noise Filer to clean up filenames - Make any changes?

 

[ajs]

@kiwijunglist
Hmmm ... try:

(\\?((sample)|(extra)|(trailer))s?\\?(.+?\.[a-z]{3,4}))

 

[kiwijunglist]

i might give up for tonight!!!! thank you.

 

[RoChess]

I would need to see movingpictures.log debug results on what MovPic is using to apply sample filter on.

Presuming of course that the log file contains all the info needed.

It could also be that the setting is not actually using regular expression, or that it demands a single entry output.

To debug, does "sample|extras" work?

I don't think the noise filter will do any good, because that only works for filenames if memory serves me.

PS: Have you considered just adjusting the "Max Filesize (MB)" values to one that would still work for your smallest actual movie, but then exclude all the extras/bonus/samples automatic? Unless of course you have those monster behind-the-scene high definition documentaries. Another solution for those is to rely on the multi-part system, and call the movie itself CD1/Part1/etc, and then the bonus CD2/Part2/etc. That way the movie only gets a single entry in Moving-Pictures, and you still have the ability to play the bonus features at the end. The only downside is that runtime will be off, as it will be calculated on both. Another alternative would be to use IMDb+ and add something like "([Bonus])" to the filename, so that it will become a separate entry in your collection that is easy to identify.

Using sample|extras should have worked though

 

[ajs]

It could also be that the setting is not actually using regular expression, or that it demands a single entry output.

        [CornerstoneSetting(
            Name = "Regular Expression Filter",
            Description = "a regular expression that matches keywords in the filename or it's parent folder indicating that the file is possible sample.",
            Groups = "|Movie Importer|Sample Filter|",
            Identifier = "importer_sample_keyword",
            Default = "sample")]
        public string SampleRegExFilter {
            get { return _sampleRegExFilter; }
            set {
                _sampleRegExFilter = value;
                OnSettingChanged("importer_sample_keyword");
            }
        }
        private string _sampleRegExFilter;

          public static bool isSampleFile(FileInfo file) {
            try {
                // Create the sample filter regular expression
                Regex expr = new Regex(MovingPicturesCore.Settings.SampleRegExFilter, RegexOptions.IgnoreCase);
                // Set sample max size in bytes and check the file size
                long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024;
                bool match = (file.Length < sampleMaxSize);
                if (match) {
                    // check the filename
                    match = expr.Match(file.Name).Success;
                    if (!match && MovingPicturesCore.Settings.SampleIncludeFolderName) {
                        // check the folder name if specified
                        match = expr.Match(file.DirectoryName).Success;
                    }
                }
                // Return result of given conditions  
                return match;
            }
            catch (Exception e) {
                if (e is ThreadAbortException)
                    throw e;

                logger.Warn("Sample file check failed: {0}", e.Message);
                return false;
            }
        }

 

[ajs]

@kiwijunglist
Try set "Max Filesize (MB) - If the filesize of the potential sample file is below this value it will be skipped." to large value, like 500 or bigger ... but:

long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024;
bool match = (file.Length < sampleMaxSize);
if(match){...

IMHO wrong logic I would have done so:

public static bool isSampleFile(FileInfo file) {
            try {
                // Create the sample filter regular expression
                Regex expr = new Regex(MovingPicturesCore.Settings.SampleRegExFilter, RegexOptions.IgnoreCase);
                // Set sample max size in bytes and check the file size
                long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024;
                bool match = (file.Length < sampleMaxSize);
                if (!match) {
                    // check the filename
                    match = expr.Match(file.Name).Success;
                    if (!match && MovingPicturesCore.Settings.SampleIncludeFolderName) {
                        // check the folder name if specified
                        match = expr.Match(file.DirectoryName).Success;
                    }
                }
                // Return result of given conditions  
                return match;
            }
            catch (Exception e) {
                if (e is ThreadAbortException)
                    throw e;
                logger.Warn("Sample file check failed: {0}", e.Message);
                return false;
            }
        }

 

[ajs]

And regexp:

(samples?)|(\\((extra)|(trailer))s?\\)

or

(\\((sample)|(extra)|(trailer))s?\\)

 

[RoChess]

@ajs, thanks for pulling the relevant code, because I did notice that file, and folder are scanned seperate.

I was expecting a full path+file match, which might explain why searching for \Extras\ or /Extras/ can fail if the folder string does not contain the 'slash' at the end.

Log file might have clarified that if it shows the true debug value on what is being used.

Also I can't remember if .Success works on regular expression arrays, in which case you would have to simplify your expressions to ensure no array results are returned.