MP-TVSeries v4.3.6 Release [2020-01-24] (4 Viewers)

[ltfearme]

@framug / @catavolt can you please use the following dll with details on the exception added to log.

 

[framug]

THX to take care about this problem

For the magicians :, no problem to download and store the picture in folder.
Unfortunately, I don't have season 4 anymore.

Here are logs for "This is us" season 2 with all providers where, we can see filenames and also, preview thumbnails :



Maybe is it a language problem ?

System.IO.DirectoryNotFoundException: Impossible de trouver une partie du chemin d'accès 'D:\PCHC\Mes documents\Team MediaPortal\MediaPortal\Thumbs\MPTVSeriesBanners\This Is Us\-langen-seasons\311714-2.jpg'.

I don't have -langen-seasons folder but, -langfr-seasons :



CU

 

[ltfearme]

Thanks, looks like it failed because the -langen-seasons directory does not exist.

Should be an easy fix when I get a chance to review.

 

[framug]

Yep,
I wonder if :
If first season exist in "fr" (other than "en" language) then, "fr" folder is created and picture is downloaded.
But, for others seasons, if it doesn't exist in "fr", plugin download "en" but, fail because no "en" folder created.
What do you think about ?

 

[ltfearme]

It's probably something like that when multiple languages are involved.

 

[ltfearme]

@framug, please test the DLL attached which has the extra check for directory exists first and if not create it.

 

[framug]

Good job !
Is working like a charm.



But, seems to not work when I click on update by this way, nor in auto-update when entering the plugin :

 

[RoChess]

which has the extra check for directory exists first and if not create it.

Often takes one line of code to make something functional, and then the fun begins to expand it to hundreds lines of code to account for anything that might go wrong by the system or something unexpected the end-user is doing

 

[framug]

@RoChess :
I hope this post is not against me.

Because if it's case, I'm going to explain to you how we code correctly to make it work in all cases.
I hope it was not an attack on me, while I do everything so that MP users can benefit from the TOP of the TOP of what does it best.


Regards.

 

[RoChess]

@RoChess :
I hope this post is not against me.

Because if it's case, I'm going to explain to you how we code correctly to make it work in all cases.
I hope it was not an attack on me, while I do everything so that MP users can benefit from the TOP of the TOP of what does it best.

Regards.

Slow down, not an attack at all. And it was aimed at @ltfearme for one (as the quote shows) being a generalized statement what software development goes through. Any code goes through this process. Allowing an input box to accept some text is one or a few lines of code, but then the underlying code to avoid incorrect input, sanitize it to avoid code-injection, make it ADA compliant, show a tool-tip for support, etc, etc. It's the stuff nightmares are build from sometimes

Recently had to add 17 try-catch statements to account for incorrect data and add some logging to make it easier to resolve a random bug, those deserve a category all by themselves