Being pragmatic yes but this could also affect plugins so there could be dialogs in any number of plugins that are broken. I guess as long as we test where we can (and I guess more people would have reported issues they were seeing).I agree that we need to look into this a bit more. On the other hand, I haven't seen any other reports related to dialogs, and I haven't seen any issues in my own testing. Scythe doesn't seem to be around much at the moment, so perhaps we should consider committing this fix for 1.4.0, and then looking into the deeper issues for 1.5.0 ?
There are so many places where dialogs are called that is nearly impossible to test them all...
I completely agree. However, I would say that of the many dialogs in MP, this one probably gets used less than most, and yet this is the only one that we have a reported error for.
I think we have to fix what we can, test what we can and then to a certain extent hope for the best.