Yep thanks Mark,
We can test can in both mode (properties on a picture or when watching picture in fullscreen -> F9 -> properties) without the fix, it should failed.
We proved what the issue was but there is potentially a bigger underlying issue in the way dialogs are now being shown (or not shown as the case may be...)
Still need @Scythe42 to comment as I think there are possibly more dialogs that could be broken and the way dialogs are called can dictate whether they work or not. The original (?) thread has the details but is is about allocating resources
Being pragmatic yes but this could also affect plugins so there could be dialogs in any number of plugins that are broken. I guess as long as we test where we can (and I guess more people would have reported issues they were seeing).I agree that we need to look into this a bit more. On the other hand, I haven't seen any other reports related to dialogs, and I haven't seen any issues in my own testing. Scythe doesn't seem to be around much at the moment, so perhaps we should consider committing this fix for 1.4.0, and then looking into the deeper issues for 1.5.0 ?