The Future of MyFilms? (2 Viewers)

[catavolt]

AW: The Future of MyFilms?

+1

 

[ftothe3]

hmm... haven't upgraded to 1.1 final yet.

did the fanart flicker error disappear when using 1.1 final + myfilms 4.8? might try it myself soon. kind of dreading upgrading now though...

 

[peque]

I'm testing it remotely so I can't be sure 100%... but I'd say that YES, backdrop flickering surfing film list has dissapeared... I'm using MyFilms 4.9.1 and MP 1.1.0 Final.

For anyone like me, that had my backdrops in same directory as needed by old MyFilms versions, I've finally managed to change to a path {film}\backdrop.jpg, as needed by last MyFilms dll, using Ant Renamer:

antp.be > Software > Ant Renamer

Same author as Ant Movie Catalog...

Just add all of your .jpg backdrops to the list, and then replace " " (space) with "." (dot), and then use regexp:

current name: (.*).jpg
new name: {$1}\\$1.jpg

bye!

 

[Dadeo]

Nice Tip Peque. But in 4.9.1 I cannot get fanart to display properly can you? Even using the provided Blue3 skin files.

On the main screen, it often only displays only one fanart (even though there are many in the fanart folder).

On the Details screen, sometimes the fanart displays correctly but often it does not. When it does display, the title (neither original nor translated) display! That made me think there is some problem matching on the title. However, when the fanart does not display on Details, the title displays, but I get an error message in MP error.log which implies the file name is too long.

2010-09-12 09:58:33.634765 [ERROR][MPMain(1)]: Exception: System.IO.PathTooLongException: The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters.
at System.IO.Path.SafeSetStackPointerValue(Char* buffer, Int32 index, Char value)
at System.IO.Path.NormalizePathFast(String path, Boolean fullCheck)
at System.IO.Path.NormalizePath(String path, Boolean fullCheck)
at System.IO.Path.GetFullPathInternal(String path)
at System.IO.FileInfo..ctor(String fileName)
at MesFilms.MesFilmsDetail.Search_Fanart(String wtitle2, Boolean main, String searched, Boolean rep, String filecover, String group)
at MesFilms.MesFilmsDetail.afficher_detail(Boolean searchPicture)
at MesFilms.MesFilmsDetail.OnMessage(GUIMessage messageType)
at MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow(Int32 newWindowId, Boolean replaceWindow, Boolean skipHistory)

The actual path I use for fanart is: C:\ProgramData\Team MediaPortal\MediaPortal\Thumbs\Skin FanArt\movies\{killers} for example. Does seem pretty long but definitely less than 260 characters and I like putting the fanart in the skin fanart folder so I can use it elsewhere as well.
Any suggestions?

 

[Guzzi]

AW: The Future of MyFilms?

Hi Dadeo,

Re fanart in main view: That is how it is made - only details view uses the multiimagecontrol to toggle through available fanarts. In main view it is only fading between the first fanarts of different movies - don't know if this would also work with the multiimagecontrol, might be worth a try ...

Re IO exception: I think, the problem is the structure of the fanart:

if (((main) || (searched == "file")) && (System.IO.File.Exists(safeName + "\\{" + wtitle2 + "}.jpg")))

The Path is fanartfolder + "safe" movie name + the names of the images themselves.

Make a dir listing and check, if there is too long pathes - if it's only some single ones, you could manually rename the file, if the filename is too long.
On programside the exception could be catched, but this would mean the fanart would not be recognized, unless other construct to be used.

I personally have all fanarts on a serverdirectory, thus the path being short enough - plus the advantage, that the fanart is available to all clients immediately.

Edit: Just tested it: The multiimagecontrol is not yet loaded in the main view - it will only be loaded when launching detailsview.
So it's not possible without changing the code - I assume it's not done to avoid slowing down scrolling through the filmlist. Maybe it could be done if loading is done in a delayed manner ...

 

[Dadeo]

Re: AW: The Future of MyFilms?

Hi Guzzi thanks for the reply:

Re fanart in main view: That is how it is made - only details view uses the multiimagecontrol to toggle through available fanarts. In main view it is only fading between the first fanarts of different movies - don't know if this would also work with the multiimagecontrol, might be worth a try ...

You must be right, but I got confused because the mesfilms.xml contains two fanart controls with two diff properties (#myfilms.Fanart and #myfilms.Fanart2). So thought it worked like TVSeries and Moving Pictures fanart, fading between two fanart images (not all of them).

Personally, I love the multiimage control, I think it works great. I did try to use it on the Main view, but I could not get it to work, as you found out! There are not that many fanart images in one movie folder, so I don't think it would slow down scrolling the list. In aMPed skin I use multiimages in many places and have no problems.

Re IO exception: I think, the problem is the structure of the fanart:

if (((main) || (searched == "file")) && (System.IO.File.Exists(safeName + "\\{" + wtitle2 + "}.jpg")))

The Path is fanartfolder + "safe" movie name + the names of the images themselves.

Make a dir listing and check, if there is too long pathes - if it's only some single ones, you could manually rename the file, if the filename is too long.
On programside the exception could be catched, but this would mean the fanart would not be recognized, unless other construct to be used.

I personally have all fanarts on a serverdirectory, thus the path being short enough - plus the advantage, that the fanart is available to all clients immediately.

Yeah, I tried moving my fanart to M:\Fanart\ but it didn't help! For example, Iron Man 2 causes the error message (and does not display fanart in Details View). I don't know exactly which fanart the multiimage control tries to load, but the longest filename is: M:\Fanart\{iron.man.2}\{iron.man.2} [-1751089959].jpg - which is far less than the 260 character limit indicated in the error message. So I don't think it is really my folder structure.

I tried commenting out the multiimage control - and the error message still occurs! Of course, if I disable fanart, no error occurs.

Oddly, as I said before, when I display Details view for other films, the fanart displays, but then the Title does not. But no error message either and the multiimage control works perfectly. Go figure I will keep testing and see if I can narrow it down some more, since you are not having this problem.

 

[Dadeo]

EUREKA! I think I figured it out. I remembered reading one of your posts Guzzi about it doing the lookup on Translated Titles vs Original Titles. I noticed that recently the IMDB script I am using started putting a ton of text in Translated Title (which I don't usually use). So I removed that long text from Tranlasted Title and Voila - fanart displays in Details View no problemo! No more error message. Now I just have to fix up the Titles and I'm good to go. Thanks for your help!

 

[Guzzi]

AW: Re: AW: The Future of MyFilms?

Hi Guzzi thanks for the reply:

Re fanart in main view: That is how it is made - only details view uses the multiimagecontrol to toggle through available fanarts. In main view it is only fading between the first fanarts of different movies - don't know if this would also work with the multiimagecontrol, might be worth a try ...

You must be right, but I got confused because the mesfilms.xml contains two fanart controls with two diff properties (#myfilms.Fanart and #myfilms.Fanart2). So thought it worked like TVSeries and Moving Pictures fanart, fading between two fanart images (not all of them).

Personally, I love the multiimage control, I think it works great. I did try to use it on the Main view, but I could not get it to work, as you found out! There are not that many fanart images in one movie folder, so I don't think it would slow down scrolling the list. In aMPed skin I use multiimages in many places and have no problems.

First of all: You're right - the second control indeed is for toggling fanart - this part is in fact taken from MoPi/TVS (CornerstoneMP) and using the Imageswapper.
I checked the code and it seems, that this is not working for movies - I got the impression, that is is intended for genrefanart only - but didn't test it. I tried to modify the behaviour to use the imageswapper for movies in mainview as well, but didn't get it to work.
I think I would have to assign backdrop.filename the path to the fanartdirectory, but as said, didn't get it to work. Maybe someone else want's to check? ....

EUREKA! I think I figured it out. I remembered reading one of your posts Guzzi about it doing the lookup on Translated Titles vs Original Titles. I noticed that recently the IMDB script I am using started putting a ton of text in Translated Title (which I don't usually use). So I removed that long text from Tranlasted Title and Voila - fanart displays in Details View no problemo! No more error message. Now I just have to fix up the Titles and I'm good to go. Thanks for your help!

... that makes absolutely sense - there is routines using translated title to create the lookupdirectory to check if fanart is locally available - and if those have "insane long text" this can throw the exception.
Anyway, good to hear, that you could fix it ;-)

 

[Dadeo]

Hey Guzzi thanks for the confirmation about the fanart in the Main Screen. Hope someone can fix that (or better yet, just use the multiimage control in both Main and Details view and forget about CornerstoneMP!)

However, in Details view fanart still does not work in some cases. If a movie has both an Original Title and a Translated Title, sometimes fanart displays but sometimes it doesn't. If I view a different movie that has multiple fanart images, and then I view a movie with a Translated Title, the fanart never displays in Details view for me. I tested using Blue3 skin files of course. Can you confirm that or not?

In my case, my movies are mostly English language films so the Movie Titles appear in AMC in the Original Title field. In MyFlims Config, Ant Master Title is Original Title. I am not clear how the Fanart Grabber tries to match fanart, but I noticed that when there is a Translated Title for a movie, it creates a new folder in the fanart folder. However, those folders are always empty. For example, for the movie Killers I have a folder {killers] with 9 fanart images and a folder {_kiss.&.kill_.-.japan.(english.title)} with none. That makes sense to me since {_kiss.&.kill_.-.japan.(english.title)} would not match any fanart in TMDB. But, when I go to Details View, the multiimage control does not work for Killers and only one fanart displays. If I remove the Translated Title, then the multiimage control works.

The same issue occurs with foreign language films. For example, for 'Un prophète' MyFilms fanart grabber accurately finds both the fanart backdrops, but it will only display one of them in Details View unless I remove the translated title.

So, I think the whole issue is with the Titles, but I am guessing. If I want fanart to display correctly, I have to remove all Translated Titles. I don't think I would call that a 'fix'

I understand why My Films is trying to match on Original Title as well as Translated Title, since users may have configured their AMC in diff ways. But why does it combine the names? For example, should it not just create one folder for 'Un prophète' and one for 'A Prophet' and then in Details view match it based on the Main Title a user selects in MyFilms config?

Anyway, don't get me wrong. I love MyFilms and I love the new fanart grabber! I'm just trying to get it to work perfectly! At least I don't get the error message anymore!

 

[Guzzi]

AW: Re: The Future of MyFilms?

Hey Guzzi thanks for the confirmation about the fanart in the Main Screen. Hope someone can fix that (or better yet, just use the multiimage control in both Main and Details view and forget about CornerstoneMP!)

Ithink it would be better to "fix" the CornerstoneMP - it's big advantage is the delayed loading of fanart - this makes scrolling better - if you would load a multiimagecontrol in e.g. the listview, I would expect severe impact on the handling ....

However, in Details view fanart still does not work in some cases. If a movie has both an Original Title and a Translated Title, sometimes fanart displays but sometimes it doesn't.

hmmm, would require to pinpoint, when it works and when it doestn't ... ;-)

If I view a different movie that has multiple fanart images, and then I view a movie with a Translated Title, the fanart never displays in Details view for me. I tested using Blue3 skin files of course. Can you confirm that or not?

I can't test, because I have TranlatedTitle for all my movies - it's same as Otitle, if no translation available.
But I checked the code, and you might be right:

if (MesFilms.conf.StrTitle1 == "OriginalTitle")
wttitle = wtitle;

sets translated title same as originaltitle and does the fanartsearch and download with that title - while in the part of the code that selects the fanart for main view:

string wtitle = MesFilms.r[MesFilms.conf.StrIndex]["OriginalTitle"].ToString();
if (MesFilms.r[MesFilms.conf.StrIndex]["TranslatedTitle"] != null && MesFilms.r[MesFilms.conf.StrIndex]["TranslatedTitle"].ToString().Length > 0)
wtitle = MesFilms.r[MesFilms.conf.StrIndex]["TranslatedTitle"].ToString();

-> it will use translatedtitle if present for fanartsearch - and will not find any...

So I would call it a bug - I personally don't have it, because I use translatedtitle as MasterTitle.

In my case, my movies are mostly English language films so the Movie Titles appear in AMC in the Original Title field. In MyFlims Config, Ant Master Title is Original Title. I am not clear how the Fanart Grabber tries to match fanart, but I noticed that when there is a Translated Title for a movie, it creates a new folder in the fanart folder. However, those folders are always empty. For example, for the movie Killers I have a folder {killers] with 9 fanart images and a folder {_kiss.&.kill_.-.japan.(english.title)} with none. That makes sense to me since {_kiss.&.kill_.-.japan.(english.title)} would not match any fanart in TMDB. But, when I go to Details View, the multiimage control does not work for Killers and only one fanart displays. If I remove the Translated Title, then the multiimage control works.

The same issue occurs with foreign language films. For example, for 'Un prophète' MyFilms fanart grabber accurately finds both the fanart backdrops, but it will only display one of them in Details View unless I remove the translated title.

So, I think the whole issue is with the Titles, but I am guessing. If I want fanart to display correctly, I have to remove all Translated Titles. I don't think I would call that a 'fix'

I understand why My Films is trying to match on Original Title as well as Translated Title, since users may have configured their AMC in diff ways. But why does it combine the names? For example, should it not just create one folder for 'Un prophète' and one for 'A Prophet' and then in Details view match it based on the Main Title a user selects in MyFilms config?

Yes, that's the way it should work - would require a fix in the plugin ...
Adding

"if !(MesFilms.conf.StrTitle1 == "OriginalTitle")"

in the above code would fix it. Unfortunately I can't compile the latest sources from sourceforge ...