Video with subtitles is corrupted with 1.4.0 pre in XP (1 Viewer)

mm1352000

Development Group
  • Team MediaPortal
  • September 1, 2008
    21,571
    8,218
    New Zealand New Zealand
    Country flag
    Also testing this patch... seems very good! :) (y)
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    @Sebastiii
    So the solution is to not have "_createFlags |= CreateFlags.PureDevice;" for XP?

    I change :
    _deviceType by DeviceType.Hardware
    and
    _createFlags to CreateFlags.HardwareVertexProcessing

    So yes i think, we should not have : "_createFlags |= CreateFlags.PureDevice;" or "_createFlags = CreateFlags.SoftwareVertexProcessing;"

    I didn't attach vs to my XP but it seems that XP can't handle CreateFlags.SoftwareVertexProcessing; or CreateFlags.PureDevice;

    Like it seems that part is only trigger for XP it should be safe, but it's don't my area so i can't really said @ 100%

    Maybe @Scythe42 knows better (for sure he's knows :p)
     

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,161
    747
    Country flag
    Hey Sebastiii, you're simply the best!
    Indeed, your patch also solves several other problems I had - crashing of renderdevice when doing facade navigation (sometimes with endless looping recovery/crash), DX errors and unability to connect the graph (without any recovery) thus VMR9 player not working and some other minor things - a quick test shows all those issues seem to be gone.
    Thanks a lot for your efforts!
     

    Holzi

    Super Moderator
  • Team MediaPortal
  • April 21, 2010
    7,930
    2,234
    Ba-Wü
    Germany Germany
    Country flag
    Well, my personal opinion is to release this as 1.4.1 hotfix (when it is tested) since MP 1.5.0 won't support XP?
    @Developers any opinions?
     

    Owlsroost

    Development Group
  • Team MediaPortal
  • October 28, 2008
    5,539
    5,037
    Cambridge
    United Kingdom United Kingdom
    Country flag
    Well, my personal opinion is to release this as 1.4.1 hotfix (when it is tested) since MP 1.5.0 won't support XP?
    @Developers any opinions?
    I personally don't have a problem with that idea, but I agree with Seb that we could really do with an opinion from Scythe42 and/or Tourettes about the fixes (as they are probably the people who understand this area the best).

    Also, before we go through the full release process for a 1.4.1 (which will eat up a lot of time for those involved) should we post an installer in Area51 for a while and get more feedback ?
     

    Scythe42

    Retired Team Member
  • Premium Supporter
  • June 20, 2009
    2,065
    2,703
    46
    Berlin
    Germany Germany
    I didn't attach vs to my XP but it seems that XP can't handle CreateFlags.SoftwareVertexProcessing; or CreateFlags.PureDevice;
    XP can deal with this nicely. But looks like the subtitle rendering part cannot deal with it on XP. No harm to branch the capabilities for XP here when the flags are set, but please not in general of course.

    The code just following the capabilities reported by the D3D device and select the highest level the GPU support. No magic here.

    Overriding stuff for XP would be possible. If we come up with a PureDevice go back a step to HardwareDevice in case it is supported. But not supporting Software Vertices would be problem for older integrated Intel GPUs as they do not have hardware vertices. If you do not allow this, they could not render anything as there is no mode available for the mat all. It is the lowest you can go without going fully software rendering if I remember my D3D caps correctly.

    So keep this in mind with these GMA3xxx GPUs when creating a final patch. Make sure you test it these GPUs as well that it does not introduce general other issues. I spent a lot of

    As said the underlying problem is in the subtitle rendering itself. But do whatever you guys think it's right for XP as long as it is just specific to XP and can later be easily removed from the code again.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    It's really not my cup of tea lol :)

    So i just find that doing that seems better (for subtitle side) but seems not only for @Guzzi right ?

    I can try to do better patch but it's not my area (and do i have one ? :p)
    So can you confirm it when i will supply a new patch, i will try to follow you but i don't have your skills :)

    Thanks Scythe for your explanation :)

    Ps : i have try to play with subtitle source and it's even worst (C++ lol), the mpcsubs.dll from 1.4.0 run fine on 1.3.0, but the 1.3.0 didn't work on 1.4.0 build.
     

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    Overriding stuff for XP would be possible. If we come up with a PureDevice go back a step to HardwareDevice in case it is supported. But not supporting Software Vertices would be problem for older integrated Intel GPUs as they do not have hardware vertices. If you do not allow this, they could not render anything as there is no mode available for the mat all. It is the lowest you can go without going fully software rendering if I remember my D3D caps correctly.

    So keep this in mind with these GMA3xxx GPUs when creating a final patch. Make sure you test it these GPUs as well that it does not introduce general other issues. I spent a lot of

    As said the underlying problem is in the subtitle rendering itself. But do whatever you guys think it's right for XP as long as it is just specific to XP and can later be easily removed from the code again.

    Can you look @ attached patch ? :)
    Thanks :)
     

    Attachments

    Sebastiii

    Development Group
  • Team MediaPortal
  • November 12, 2007
    16,433
    10,254
    France
    France France
    Country flag
    So keep this in mind with these GMA3xxx GPUs when creating a final patch. Make sure you test it these GPUs as well that it does not introduce general other issues. I spent a lot of

    As said the underlying problem is in the subtitle rendering itself. But do whatever you guys think it's right for XP as long as it is just specific to XP and can later be easily removed from the code again.


    What about : :)

    Hey Sebastiii, you're simply the best!
    Indeed, your patch also solves several other problems I had - crashing of renderdevice when doing facade navigation (sometimes with endless looping recovery/crash), DX errors and unability to connect the graph (without any recovery) thus VMR9 player not working and some other minor things - a quick test shows all those issues seem to be gone.
    Thanks a lot for your efforts!
    How can try on GM3xxx ?
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    A [solved] How to Play All Videos in a List watch/edit Videos 3
    O 1.25.0 Codecs and Video Format for PlayStation 2 Codecs, External Players 0
    g0rsq Info box randomly popping up when watching TV or other video MediaPortal 2 Newcomers Forum 1
    I Video Playback Stuttering General Support 45
    B some videos jerky Television (MyTV frontend and TV-Server) 0
    B MP 2.2.3 Error playing videos from NAS Submit: Bug Reports 2
    T Kurze Tonaussetzter bei Videos und TV Allgemeines Supportforum 1
    mrmojo666 [Tv Server Plugin ]Direct Show Video Control Plugin 0.0.0.1 for Hauppauge PVR cards MediaPortal 1 Plugins 0
    ajs [Proposal] Video embedded cover MediaPortal 1 1
    G [solved] Black Screen on all videos after upgrading to either 1.23 or 1.24 from 1.22 General Support 4
    H random black screen live tv and videos (amended) General Support 0
    404 [solved] Live TV...video and audio freeze General Support 20
    R kein Ton bei TV, Video, Aufnahme, Musik Allgemeines Support- und Diskussionsforum 0
    U [solved] Dynamic Refresh Rate for 23fps video Watch / Listen Media 1
    J Debug OnlineVideos, How To? OnlineVideos 1
    A MP2.2.2, understanding movies/videos/tv and WTV recordings. General 16
    C Problem playing videos created on IPhone X and Samsung S9 General Support 2
    H [solved] Video database genres, sort titles and collection thumbnails Newcomers Forum 12
    M How to Watch my videos from my Media Portal to My TV without TV Tuner Newcomers Forum 1
    cbr954rr Issue BOOTSUWRNQ with online videos? Plugin Development 1
    A Working server, no video playback on client General 5
    Megane [Configuration] Be more specific in Video Codec Improvement Suggestions 0
    M Online Video Plugin V.2.32 keine Installtion unter MediaPortal 1.22 ? TV / Streaming 3
    C where is the Online Videos plugin General Support 1
    LeeKelly Online Videos Breaks IPTV channels and scanning Installation, configuration support 1
    Similar threads

























    Top Bottom