[solved] Cannot get FH Holiday to work (1 Viewer)

[budinsky]

@budinsky Tell me when you download it, I'll delete it. It's personal information, after all.

Downloaded.

 

[budinsky]

I just tried deleting the contents of FanartHandler.Holidays.xml and it works!



Last error is with Daylight Savings time. When I have them in it errors.
RefreshHolidayProperties: Year, Month, and Day parameters describe an un-representable DateTime.

This is caused because my timezone does not have DST. I wanted to know when the other states had it though.

    <Holiday name="Daylight Savings Time Begins" shortname="DaylightSavings|DaylightSavingsBegin">
        <DSTStart />
        <NameDE>Beginn der Sommerzeit</NameDE>
    </Holiday>
    <Holiday name="Daylight Savings Time Ends" shortname="DaylightSavings|DaylightSavingsEnd">
        <DSTEnd />
        <NameDE>Ende der Sommerzeit</NameDE>
    </Holiday>

 

[ajs]

I have seen issues like this when the local clock is in an unexpected format. Mine is dd/mm/yyyy.

There is no date string work in the code, it uses C# intrinsic functions, it shouldn't be a problem.

I just tried deleting the contents of FanartHandler.Holidays.xml and it works!

Strange ... Strange ... Try this file out of the box, without your edits. mediaportal-fanart-handler/Installer/config/FanartHandler.Holidays.xml at master · yoavain/mediaportal-fanart-handler

 

[budinsky]

There is no date string work in the code, it uses C# intrinsic functions, it shouldn't be a problem.

Strange ... Strange ... Try this file out of the box, without your edits. mediaportal-fanart-handler/Installer/config/FanartHandler.Holidays.xml at master · yoavain/mediaportal-fanart-handler

I edited my answer as you responded. I can confirm the issue is because my timezone has no DST.
When I changed my timezone to Melbourne I got no errors.

But it's handy to know when the other states in Australia start and finish DST.
Maybe a feature enhancement?

I looked it up and DST starts first Sunday in October, and ends first Sunday in April.
How would I edit the xml to do this?

Father's day is first Sunday of September. I don't know if the code handles these.

 

[ajs]

I edited my answer as you responded. I can confirm the issue is because my timezone has no DST.

Thanks, I'll have a look, today or possibly tomorrow, you can delete the DST sections for now, I think it should help.

 

[ajs]

DST

Try this ...

 

[budinsky]

Try this ...

DST error resolved with the new version you provided.

Does this update provide DST or just prevent the error?

 

[ajs]

Does this update provide DST or just prevent the error?

Added a check that if the time zone does not have a DST, then do not try to define it.

DST error resolved with the new version you provided.

Thanks, I'll update the release then.