Store language(s) from MediaInfo (2 Viewers)

[barneh]

Finally ltfearme...

Attach you will find the tested code for setting the Special episode as Watched.

I have also looked into how artwork are fetched. And as I can see it is only fetched all the English artwork. Why? I haven't figure that out yet
Because there are no language used when fetching the artwork, so I don't understand why it's not fetching other languages. But I see that this feature can be useful, but I have also seen artwork on thetvdb.com uploaded/ marked with the wrong language...

 

[ltfearme]

IT definitely picks up artwork from different languages, at least it did when originally implemented. Check out GetBanner.cs and see if it correctly compares again your chosen language.

  public int CompareTo(T other)
  {
  // Sort by:
  // 1. Local Language
  // 2. Highest Rated
  // 3. Number of Votes

  double thisArtwork = this.Language == OnlineAPI.SelLanguageAsString ? 100.0 : 0.0;
  double otherArtwork = other.Language == OnlineAPI.SelLanguageAsString ? 100.0 : 0.0;

  if (this.Rating == other.Rating)
  {
  thisArtwork += this.RatingCount;
  otherArtwork += other.RatingCount;
  }

  thisArtwork += this.Rating;
  otherArtwork += other.Rating;

  return otherArtwork.CompareTo(thisArtwork);
  }

There is a actually a bug in that code, but it would be a slim chance of hitting it. It basically gives more weight to artwork of your preferred language and its rating, it does the job but could be improved.

The key point for you to check is if OnlineAPI.SelLanguageAsString is correct and all the language property of the poster is correct, that is assigned here:

seriesPoster.Language = banner.SelectSingleNode("Language").InnerText;

 

[barneh]

You right, it does... I was looking through the code a little bit more after I posted.. since I was confused about how it worked!
And the DownloadBanner method takes a onlineLanguage as a parameter, and that parameter is always "en".
That's why it download other artwork, but delete the since it is not the "right" language.

I'll make a fix for the artwork to

 

[ltfearme]

Is that a regression from your patch? It must be as someone else would of complained by now

 

[barneh]

Well.. It can be...
My patch works, for series and it's data, but the artwork will be in a wrong language.

 

[ltfearme]

I committed your patch, if you can make sure you do a get so your local is aligned that would be great.

I haven't look at you patch yet, but will test with the default behaviour and make sure it still works as expected when I get a chance. Guess the key thing to test is that if you do have a special which is watched then that special is counted as watched.

 

[ltfearme]

I think you have a logic bug because I have my episodes counted as watched for everything at the series level.

 

[ltfearme]

See attachments, its correct at the season level but wrong at the series level. It should report 19 unwatched and 1 watched at the series level.

Just to be clear, I have only watched a single special.

 

[barneh]

Okay... That was strange.... I will take a look at it!

 

[barneh]

I think you have a logic bug because I have my episodes counted as watched for everything at the series level.

Hmm.... I don't get that behaviour
You should have had 10 unwatched and 10 watched with the feature ON, and 19 unwatched and 1 watched with the feature OFF in Series view.

As you see in my run I get for "Kampen om Tungtvannet" 5 unwatched and 2 watched with the feature ON, and 6 unwatched and 1 watched with the feature OFF in Series view.