Store language(s) from MediaInfo | Page 4

Discussion in 'My TVSeries' started by Edalex, January 31, 2015.

  1. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,457
    Likes Received:
    4,241
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,385 / 0
    Home Country:
    Australia Australia
    Don't worry, I think I managed to restore my changes.


     
    • Thank You! Thank You! x 2
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,457
    Likes Received:
    4,241
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,385 / 0
    Home Country:
    Australia Australia
    I made some minor updates in r2109 so please do an SVN update before making any more fixes/changes to this patch ;)

    I will review the update in GetSeriesEpisodeCounts() method later this week.
     
  4. barneh
    • Premium Supporter

    barneh MP Donator

    Joined:
    February 4, 2010
    Messages:
    242
    Likes Received:
    27
    Location:
    Malmö
    Ratings:
    +53 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    I'm @ r2109 now!

    And I made some idiotic mistakes last time at did an update.... my bad - Apologize for that!
     
    • Like Like x 2
  5. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,457
    Likes Received:
    4,241
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,385 / 0
    Home Country:
    Australia Australia
    Hey barneh,

    just so im clear on the functionality that you intended for the cCountSpecialEpisodesAsWatched option. Does that mean if you have a special episode in your database it will count as watched regardless of its watched status?

    If so I did not intend to make the cCountSpecialEpisodesAsWatched as default enabled in my last commit ;). I will change it back to false.
     
    Last edited: February 18, 2015
    • Informative Informative x 1
  6. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,457
    Likes Received:
    4,241
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,385 / 0
    Home Country:
    Australia Australia
    There is still more to be done if you want to always count special episodes as watched.

    The DBEpisode.GetSeriesEpisodeCounts() does not get called during an import. I suggest you put a break point here in OnlineParse.cs:
    Code (Text):
    1.  
    2.   void asyncEpisodeCounts(object sender, DoWorkEventArgs e)
    3.   {
    4.   Thread.CurrentThread.Priority = ThreadPriority.Lowest;
    5.   List<DBSeries> allSeries = (List<DBSeries>)e.Argument;
    6.   BackgroundWorker worker = sender as BackgroundWorker;
    7.   int nIndex = 1;
    8.   var episodesForCount = DBSeries.GetEpisodesForCount();
    9.   foreach (DBSeries series in allSeries)
    10.   {
    11.   worker.ReportProgress(0, new object[] { series, nIndex++ });
    12.   DBSeries.UpdateEpisodeCounts(series, episodesForCount);
    13.   }
    14.   e.Result = allSeries.Count;
    15.   }
    16.  
    fyi, a couple years ago I think I made some changes to episode counting as it was too slow.
     
    Last edited: February 18, 2015
    • Informative Informative x 1
  7. barneh
    • Premium Supporter

    barneh MP Donator

    Joined:
    February 4, 2010
    Messages:
    242
    Likes Received:
    27
    Location:
    Malmö
    Ratings:
    +53 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    Yes... Regardless if the special episode exist or not, it should count it as watch. So default should be false :)
     
  8. barneh
    • Premium Supporter

    barneh MP Donator

    Joined:
    February 4, 2010
    Messages:
    242
    Likes Received:
    27
    Location:
    Malmö
    Ratings:
    +53 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    I always forget the import :|
    I'll do a test on imports.

    Thanks for the heads up :)
     
    • Thank You! Thank You! x 1
  9. ltfearme
    • Premium Supporter

    ltfearme Community Plugin Dev

    Joined:
    June 10, 2007
    Messages:
    6,457
    Likes Received:
    4,241
    Gender:
    Male
    Occupation:
    Software Test Engineer
    Location:
    Sydney
    Ratings:
    +5,385 / 0
    Home Country:
    Australia Australia
    Also test deletion of episodes,season,series from GUI Action menu. Toggling Show All Episodes from Options menu etc. These affect the counts when executed.

    Another thing I noticed about the patch is that when you toggle option in GUI, it updates the series counts on the main thread. It should do this on a background thread.
     
  10. barneh
    • Premium Supporter

    barneh MP Donator

    Joined:
    February 4, 2010
    Messages:
    242
    Likes Received:
    27
    Location:
    Malmö
    Ratings:
    +53 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    I put the check in DBSeries.GetEpisodesForCount(), so it shouldn't go slower with this feature...

    Fixed!

    I have done some tests, but I feel I need to do more... Hopefully I get some time to do them later this week, so I can commit a new patch after that :)
     
    • Like Like x 1
  11. barneh
    • Premium Supporter

    barneh MP Donator

    Joined:
    February 4, 2010
    Messages:
    242
    Likes Received:
    27
    Location:
    Malmö
    Ratings:
    +53 / 0
    Home Country:
    Sweden Sweden
    Show System Specs
    After testing i found out that it was better to do the change in DBSeries.UpdateEpisodeCounts() then DBSeries.GetEpisodesForCount() :)
     
    • Thank You! Thank You! x 1
    • Informative Informative x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!