The Future of MyFilms? (1 Viewer)

Status
Not open for further replies.

zebons

Portal Pro
January 2, 2006
1,484
114
Re : The Future of MyFilms?

New version :
seach and Update done with a list of item to be taken into account.
Corrected some bugs with emty property movies and search function
Fixed pb on Int or decimal field for searching or updating (Rating, Number)
Fanart and Fanart2 now initialized when entering plugin
Action_Context_Menu managed on main screen (Focus on BTN_Layout ID=6)
some others encounterd pbs...

To be tested.
Thanks
 

Attachments

  • MyFilms v0.4.9.1.mpe1
    30.6 KB

Guzzi

Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,159
    750
    AW: Re : AW: Re : AW: The Future of MyFilms?

    PS: sorry for bothering you again, but I have a second question for skinning:

    In MesFilmsDetails.xml, the ID101 is used to start playback of the selected mediafile.
    I have moved this to default (away from the menu), so that when in Detailsview, pressing enter just starts the movie.
    To be able to switch through several Infoscreens, I have also added 3 "pseudo"controls with IDs 10001, 10002, 10003, so I can use up/down to change between those controls and use the visible tags to display 4 Pages of Infos for the movie.
    e.g.:
    <type>fadelabel</type>
    <id>1</id>
    <label>#myfilms.resolution</label>
    <visible>Control.HasFocus(10003)</visible>

    Unfortunately, I can't start the movie, when the focus is on any of those "pseudo"-button-controls. I tried <action> and <hyperlink>, but this didn't work for me, or I didn't put the right ID in action control...

    Can you tell me, what ID I would have to use to be able to start the movie on any of the 4 (3) controls? Or is it required, that separate IDs have to be inside the Plugin?

    <control>
    <type>button</type>
    <id>101</id>
    </control>

    <control>
    <type>button</type>
    <id>10001</id>
    </control>

    <control>
    <type>button</type>
    <id>10002</id>
    </control>

    <control>
    <type>button</type>
    <id>10003</id>
    </control>

    Thanks,
    Guzzi
    I'm not sure to really understand .You Have create three tabs for having several screens to display all informations ? And you want to have the Play button active in each tab ?
    Can you send me your skin files ?
    PS: ACTION_CONTEXT_MENU is now managed on the main screen.

    Hi Zebons,

    let me explain, further:
    I have created 3 additional controls and have now 101, 10001, 10002, 10003 an mainscreen, while the rest is in the left menu.
    So going "up and down" goes through 4 views (via visible tag), geing left opens the menu with options, etc.

    When pressing enter in Detailsscreen, the movie is started (101 has focus). But when changing the "view", the focus changes to 10001, 10002, 10003 - and pressing enter no more starts the movie.

    I tried <hyperlinkit> and <action> tags without success - but maybe I just did not enter the correct ID as action for the "pseudo-controls".

    Attached my MesFilmxDetails (work in progress, so might be somehow "strange"...)

    Page 1 - Summary
    <visible>Control.HasFocus(101)</visible>
    MesfilmDetails-Page1-VisibleOnID101.JPG

    Page 2 - Description
    <visible>Control.HasFocus(10001)</visible>
    MesfilmDetails-Page2-VisibleOnID10001.JPG

    Page 3 - Comment
    <visible>Control.HasFocus(10002)</visible>
    MesfilmDetails-Page3-VisibleOnID10002.JPG

    Page 4 - Technical Infos
    <visible>Control.HasFocus(10003)</visible>
    MesfilmDetails-Page4-VisibleOnID10003.JPG
     

    Attachments

    • MesFilmsDetail.xml
      30.6 KB

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,159
    750
    AW: The Future of MyFilms?

    Hi Zebons,

    and I have a similar problem with integrating Movietrailers:

    I have added a "pseudo buttoncontrol" to the left menu and tried to launch a trailer for the current movie (trailerpath&Filename is in field #myfilms.borrowed).
    I tried some tags, that might make this possible, so far without success, (but still trying, so far I wastn't able to launch internal g_player by ID - will try launching external application with parameter).

    This is the control I added to left menu:
    <control>
    <type>button</type>
    <description>Launch external Trailer</description>
    <id>10201</id> <!-- pseudoID is not present in plugin -->
    <hyperlink></hyperlink>
    <action></action> <!-- 102 Play current movie. Unpauses movie and sets playspeed to 1x. Can b used in VideoFullScreen.xml window id=2005 -->
    <application></application> <!-- start external application -->
    <arguments></arguments> <!-- arguments for external application -->
    <script></script> <!-- start external script -->
    <onup>102</onup>
    <ondown>107</ondown>
    <onright>101</onright>
    <label>Spiele Trailer</label>
    </control>

    MesfilmDetails-LaunchTrailer.JPG

    Since we're featurefreeze, maybe you can give me some help here, how to properly use the control tags to start the trailerfile in the videoplayer?

    Appreiate any help,

    thanks, Guzzi

    For future myfilmsversion it would be the easiest to add a controlID that can be used to call the player via the plugin - handing over the trailerlist via borrowed-field - so same logic as today multipartmovies are played (with e.g.: #myfilms.borrowed = "e:\trailer\titanic.mov; e:\trailer\titanic_theatrical.mov")
     

    Helios61

    Retired Team Member
  • Premium Supporter
  • January 30, 2008
    4,586
    875
    64
    NRW
    Home Country
    Germany Germany
    AW: The Future of MyFilms?

    Hi zebons, z3us and guzzi!

    I only want to thank you for your effort here with Myfilms! I think, this is a example for great teamwork! It's hard to wait for MyFilms 5.0!

    Big :D

    Helios
     

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,159
    750
    AW: Re : The Future of MyFilms?

    New version :
    seach and Update done with a list of item to be taken into account.
    Corrected some bugs with emty property movies and search function
    Fixed pb on Int or decimal field for searching or updating (Rating, Number)
    Fanart and Fanart2 now initialized when entering plugin
    Action_Context_Menu managed on main screen (Focus on BTN_Layout ID=6)
    some others encounterd pbs...

    To be tested.
    Thanks

    Hi Zebons,

    thanks a lot for the new version and all your efforts!!! I really appreciate that!

    Here is my feedback after testing:

    New version :
    seach and Update done with a list of item to be taken into account.
    Thanks a lot!!!!


    Action_Context_Menu managed on main screen (Focus on BTN_Layout ID=6)
    Thanks! Works nicely and solves the problem of contextsearching! :)
    I have some minor issues left:
    a.) Could the focus be set to ID 4 (Search) - because in normal usage, especially context search, this is what you use. Layout is rarely changed, but searchfunction very often.
    b.) Could you do it so, that when pressing the context-button again, the focus goes back to former control? I think this can be done by also let ID4 react to context-event and let it change focus back to main screen?
    c.) the context does not work in mesfilmdetails, should be the same for consistant usage (Focus on ID107 - "update")




    1.) Old movie infos when (re-)entering plugin with menu choice:
    [...] You could either reset it or preload it with a “defaultfanart” instead – Whatever you do, it should be the same as for initial starting the GUI – so just resetting is probably this quickest fix?
    Fanart and Fanart2 now initialized when entering plugin
    I still have the same problem, that fanart is loaded when reentering the plugin while the dialog is displayed to select the DB. AFTER selecting the DB, it is cleared - so maybe you need to move the initialization a bit earlier in the code (before the dialog is launched)?

    Mesfilm-Reentering PluginFromHomeAfterDetailpage.JPG

    (Low prio I think, could stay as is for release).


    12.) Search related Movies by Properties and Search Global on All properties - propertytranslation, sortorder, propertyrestriction:
    Propertytranslation: Done
    Just one thing: There is a new property exposed: myfilms.contents_id - I assume, it's internally used - similar to dateadded?
    There is also no translation in strings_xx present - and probably not needed? When using it in search with numbers, the wellknown exception (string/number conflict) appears.

    Sortorder:
    Works fine for the display for the selection of the searchproperty, but does not work for the searchresults in globalsearch in all properties (when displaying the selectiondialog with searchresults in all properties); could you please do the order of the results for global search, that is presented for selection, also in the same order as defined in <Searchlist>? This makes sure the more important are presented on top - as user has configured sortorder in <Searchlist>.

    Propertyrestriction:
    Works fine.


    13.) Global Search – property „number“ gives an exception:
    Fixed pb on Int or decimal field for searching or updating (Rating, Number)
    Fixed for both rating and number, but new bug is introduced, see separate issue below.


    15.) dateadded field is no more properly exported to the OptItems (already in the last version you posted):

    Guzzi:
    It still works as a defined view and as sortitem (and displays the date in those views).
    Zebons: Dateadded is the conversion from string to date of the Date field. So it'd be used only for internal coding (essentially for sort problems).
    So what do you recommend me to do? I don't get the "Dateadded" any longer displayed as "#myfilms.item2" - should I change it to #myfilms.date? should the ID then be changed to >1< instead >1033<?
    I also tried replacing
    <entry name="AntViewItem2">DateAdded</entry>
    with
    <entry name="AntViewItem2">Date</entry>
    for use with attached skin, but still didn't get date displayed?
    Can you please give me a feedback what to do? Is it planned not to use the Optitems anymore (because all properties are now exported anyway)? What's the difference between e.g. exporting producer via #myfilms.producer and #myfilms.item1?
    I have this problem only with date/dateadded - other properties can be assigned to the optionalitems. (and this problem is new since 3 versions).
    Thanks in advance for clarifying this to me :)


    16.) z3us’s request for aspectratio - #myfilms.aspectratio for Logorules:
    Zebons:
    I'll try to add it.
    As z3us said, it could be calculated by: aspectratio = leftstring(resolution)/rightstring(resolution) - of couse it's a bit more, changing string to numbers and making sure, there is no division by zero etc.
    I didn't see this property yet in debuglog.

    18.) Exception when searching for related movies by rating:
    Fixed.


    19.) searching for related movies with empty property gives exception
    When searching for related movies e.g. by borrower (those are all empty in my DB) or by date (some are empty in DB), an exception is thrown, when the selected movie has an empty property.
    Expected behavior would be, that all movies are found, that also have an empty related propertyfield.
    Corrected some bugs with emty property movies and search function
    Exception is fixed, also the mentioned example with search related movie by borrower works - and displays ALL movies ("Selection Borrower []")
    Remaining bug: It does not work properly in "mixed situations - that is: When the selected movie has empty property, but there are only some other movies with also empty properties.
    In this case expected behavior would be to show all movies with also have empty property, not the others. Existing behavior is, that ALL movies are displayed.
    I tested with a movie, that has no producer info - resulting in full movie list. ("Selection producer []")


    20.) Obsolete IDs (4515, 4516, 4517) in language file:
    Deleted IDs from strings_de and seems no more initialized/required.


    New:


    21.) properties not translated in selectiondialog when searching for related movies on properties
    Dialog displays DB-fieldnames, should use labels from strings_xx to match the names elsewhere - otherwise you get presented a mixture of db-recordnames and translated labels.


    22.) Translation of "Selection" in strings_xx.xml:
    Low prio, but I would recommend to also translate the "selection" string - because it is used in many skins to show the current filtersetting - thus it should be localized.


    23.) Search by properties - Search for .number throws exception on alphanumeric searchexpression:
    When doing a global search for property "number" with searchsting e.g. "a" an exception is thrown.
    Expected behavior: A popup should inform that no items have been found / matched the searchstring.


    24.) Search by properties - Search for .rating throws exception on alphanumeric searchexpression:
    When doing a global search for property "number" with searchsting e.g. "a" an exception is thrown.
    Expected behavior: A popup should inform that the searchexpression is not valid.

    2010-04-12 02:59:09.538573 [Info.][MPMain(1)]: Exception: System.Data.SyntaxErrorException: Syntaxfehler im Ausdruck.
    bei System.Data.ExpressionParser.Parse()
    bei System.Data.DataExpression..ctor(DataTable table, String expression, Type type)
    bei System.Data.Select..ctor(DataTable table, String filterExpression, String sort, DataViewRowState recordStates)
    bei System.Data.DataTable.Select(String filterExpression, String sort)
    bei MesFilms.BaseMesFilms.LectureDonnées(String StrDfltSelect, String StrSelect, String StrSort, String StrSortSens, Boolean all)
    bei MesFilms.BaseMesFilms.LectureDonnées(String StrDfltSelect, String StrSelect, String StrSort, String StrSortSens)
    bei MesFilms.MesFilms.GetFilmList[T](T gSelItem)
    bei MesFilms.MesFilms.SearchMoviesbyProperties(String[] wSearchList)
    bei MesFilms.MesFilms.OnMessage(GUIMessage messageType)
    bei MediaPortal.GUI.Library.GUIWindowManager.SendMessage(GUIMessage message)


    24a.) Search by properties - Search for .rating throws exception on searchexpression with komma - no numbers with kommas possible ( e.g. "1,3"):
    The searchstring is expecting a dot (".") as komma. You could convert the comma to a dot or catch the exception and inform about invalid expression (I would convert it, makes it more compatible).


    25.) Search by properties - Search for .rating does not behave userfriendly in searching the searchexpression:
    While in properties with textsearches you always search "*searchexpression*" it seems the handling in rating is different, because of the numeric type of the property.
    Example: Searchstring "7" shows as "Selection Search in rating [*7*]" - but only displays all movies with rating of 7,0.
    Expected behavior:
    Searchexpression "7" should do a search like [7*] (if it would be text, it's just for explanation) - so showing all movies where rating starts with 7.
    Searchexpression "7,5" would then do a [7,5*] select - showing all movies with rating starting with 7,5 (also e.g. "7,523" - as there are some scraper storing more than 1 digit after the comma).


    25.) Search by properties - Search for .dateadded throws exception on numeric searchexpression:
    2010-04-12 03:15:47.221739 [Info.][MPMain(1)]: Exception: System.Data.EvaluateException: Die Operation 'Like' kann nicht an System.DateTime und System.String durchgeführt werden.
    bei System.Data.BinaryNode.SetTypeMismatchError(Int32 op, Type left, Type right)
    bei System.Data.LikeNode.Eval(DataRow row, DataRowVersion version)
    bei System.Data.BinaryNode.Eval(ExpressionNode expr, DataRow row, DataRowVersion version, Int32[] recordNos)
    bei System.Data.BinaryNode.EvalBinaryOp(Int32 op, ExpressionNode left, ExpressionNode right, DataRow row, DataRowVersion version, Int32[] recordNos)
    bei System.Data.BinaryNode.Eval(DataRow row, DataRowVersion version)
    bei System.Data.Select.AcceptRecord(Int32 record)
    bei System.Data.Select.GetLinearFilteredRows(Range range)
    bei System.Data.Select.SelectRows()
    bei System.Data.DataTable.Select(String filterExpression, String sort)
    bei MesFilms.BaseMesFilms.LectureDonnées(String StrDfltSelect, String StrSelect, String StrSort, String StrSortSens, Boolean all)
    bei MesFilms.BaseMesFilms.LectureDonnées(String StrDfltSelect, String StrSelect, String StrSort, String StrSortSens)
    bei MesFilms.MesFilms.GetFilmList[T](T gSelItem)
    bei MesFilms.MesFilms.SearchMoviesbyProperties(String[] wSearchList)
    bei MesFilms.MesFilms.OnMessage(GUIMessage messageType)
    bei MediaPortal.GUI.Library.GUIWindowManager.SendMessage(GUIMessage message)

    I suppose searching is not at all possible with dateadded, right? So can you confirm, that always "date" should be used instead?
    If yes, nothing to do - maybe you want to prevent the user to add this field to the list in the GUI? IMHO prio low.


    26.) Search by properties does not properly filter results when no match is found:
    When there is NO match in a search for a certain property, all movies are displayed instead of none.
    Expected behavior: A popup should inform that no items have been found / matched the searchstring.
    Examples:
    Search for property "number" with a number, that does not exist ("111111111111")
    Search for property "translatedtitle" with "aaaaaaa" - ("Selection Search in property: translatedtitle [*aaaaaaa*]")
    (Remark: When searchstring exists in at least one movierecord, proper selection is done)



    27.) Global Search in all properties is broken - does not use proper filter and always displays fullmovielist:
    The Search itself seems to work, but regardless what propertyselection you choose, always all movies are shown
    Expected behavior: List of the resultset counted in the selectiondialog should be displayed.

    Example:
    Searching for "glatzk" shows me 1 result in originaltitle and 2 results in description. When selecting "originaltitle" as property, all movies are displayed instead of just the single one found - while Selection shows "Selection originaltitle [glatzk]".
    To compare when doing a search by property originaltitle, the selection is: "Selection Search in originaltitle [*glatzk*]"

    So to me it seems, you do an exact match instead of a "like", thus no results are found.

    I made a "crosstest": Doing a globalsearch in all properties with a searchexpression, that does EXACTELY match a property does show lot's of results in the selectiondialog - and after selecting exactly one record with the exactly matching property.


    28.) Grabbing "subitems" in "search related movies by properties" is broken.
    When doing a "contextsearch, that is "search related movies by properties", in the selectiondialog no more subirems are displayed for choosing what to search for - so it seems, the grabbing of the subitems is broken - instead only the complete content of the selected property is shown in one line. As result, in most propertysearches for related movies, only the movie itself is displayed.
    Expected behavior: After selection of the property to search in for the selected movie, the content should be grabbed and subitems separated to be displayed for selection as searchexpression.

    I think, that a "case-statement" is anyhow required to handle certain special situations, so I post as follows the expected behavior for all the properties available and suggestion on how to handle it. The specialhandling (in comparison the standard subitem grabbing) is a suggestion - it gives usable results to the properties, that would otherwise be useless for a contextsearch.


    A) Standrardhandling, that is: subitemgrabbing the words/expressions from the property of the selected record:
    A1) Properties, that should be standard "subitem-grabbed" (grabbed for single words and numbers as words included in the propertyrecord) and all those subitems shown as possible searchexpressions in the property:

    TranslatedTitle (subitems allow to search for related movietitles, e.g. "Terminator salvation" -> "terminator", "salvation")
    OriginalTitle
    FormattedTitle
    Country
    Category

    A2) Personrelated Infos should also be grabbed for words, allowing to e.g. search for records that have the actor in different writing, e.g. "Christian Bale" -> "Chrstian", "Bale" -> would also find "C. Bale") or to find persons with same lastname. (The fullname search for related movies is already perfectly done with personrelated search).

    Actors
    Director
    Producer

    A3) Description and Comments should also be subitemgrabbed for words. Because the words can be a lot, I would suggest to sort the result by length of the words, having the longest words at the top - they will be most distinct to search for.

    Description (subitems allow to search for certain keywords, that might be in other movies description)
    Comments

    B) No Subitemgrabbing:
    Those properties usually have only one value, that does not need subitemgrabbing and just allow to search for movies with the same value:

    Checked
    MediaLabel
    MediaType
    VideoFormat
    VideoBitrate
    AudioFormat
    AudioBitrate
    Resolution
    Framerate
    Languages
    Subtitles
    Date
    Size
    Disks
    Borrower
    URL

    C) "Useless" properties:
    Those properties have no use for contextsearch (I disabled them in config), the nontextformat properties shouldn't be used anyway, right?:

    Picture
    Contents_Id
    Number
    DateAdded


    D) Specialhandling: That is: tandard subitemgrabbing would not be useful for contextrelated search and a specialhandling to be done:
    D1) Specialhandling: Rating should manually provide a choice for related search;
    I would suggest: 5 possible selections (example for rating = "7,5" for selected movie): "7,5" (same as current rating), "from 7 to <8" (all movies where rating starts with 7), ">7,5" (all movies with same or better rating than selected), "from 6 to <7" (one class below) and "8 to <9" (one class above),

    Rating

    D2) Specialhandling: Year should manually provide a choice for related search;
    (example for year = "2008" for selected movie); suggestion: "2008" (current year), "2007" (last year), "2009" (next year).

    Year

    D3) Specialhandling: Length should manually provide a choice for related search;
    (example for Length = "100" for selected movie); suggestion: "100" (exact current length), "95 - 105" (Small Range: +/- 5 %), "90 - 110" (Medium Range: +/- 5 %), "80 - 120" (Large Range: +/- 5 %),

    Length

    D4) Specialhandling: Source could be subitemgrabbed for parts of the path starting from left to right (full path with filename) - thus allowing to get a list of all movies stored in a certain location.
    Example: "\\NAS-Storage-1\movies\action\T\Terminator Salvation\T4.avi" -> subitems: "\\NAS-Storage-1", "\\NAS-Storage-1\movies", "\\NAS-Storage-1\movies\action", "\\NAS-Storage-1\movies\action\T", "\\NAS-Storage-1\movies\action\T\Terminator Salvation", "\\NAS-Storage-1\movies\action\T\Terminator Salvation\T4.avi"

    Source

    29.) Open featurerequests:
    Should we collect the open feature requests from this thread somewhere, so they don't get lost and can be evaluated after next stable release?
    I would suggest to open a separate thread and always updating the first post - what do you think?


    Uff, this was quite a lot - but let me repeat, that I am very, very happy with this upcoming release and it's improvements - it's a real pleasure to use them and brings a huge valueadd !!! Thanks again!

    Guzzi

    PS: As always, attached updated german translation...
     

    Attachments

    • strings_de.xml
      30.6 KB

    Alesfrancor

    Portal Pro
    March 2, 2010
    56
    5
    Home Country
    Spain Spain
    Re: AW: The Future of MyFilms?

    Hi zebons, z3us and guzzi!

    I only want to thank you for your effort here with Myfilms! I think, this is a example for great teamwork! It's hard to wait for MyFilms 5.0!

    Big :D

    Helios


    +1

    I'm following your great working. Amazing. We will have a great new version nearly.

    :D:D:D
     

    Guzzi

    Retired Team Member
  • Premium Supporter
  • August 20, 2007
    2,159
    750
    AW: The Future of MyFilms? - Trailer Support

    Hi Zebons,

    I tried several approaches to integrate trailers without changes of the plugin itself and just with skinning, but this doesn’t really work … at least I wastn't successful with that.

    So I made a description on how this can be done (again: close to the existing architecture with focus to only little modifications required).


    Intension:
    Integration of trailers in the plugin and the user’s workflow.
    This should be done by taking care about possibilities and with respect to little implementation efforts.
    Today, all trailers are separate from the movieDB and do not allow an integrated workflow.

    Solution:
    4 things have to be done:
    a) Trailers have to be connected to the DB- records
    b) Trailers must have the ability to be "played"
    c) Filteroption to only show records (=movies) with existing trailers for easier selection
    d) Improved workflow (search randon movie/movie with trailer by properties)

    General approach:
    Use existing techniques already in the plugin and mostly just add some controls plus some logic.
    a) connecting trailer to the DB:
    Most HTPC-DBs probably don't use the borrowers field, so I plan this field to use for trailersupport (but could be any other text-field, could be made configurable, if you think that's necessary).
    The field will be used the same way, as "source" - so it contains one (or several) trailers with full path, same as the main movies source/file info in source field.
    Putting this info in the #myfilms.borrower field could be done with an external script (or e.g. AMC-Updater by searching for files containing title and "trailer" in filename and adding it to the field, but that's change in AMCudater and not myfilms part), for now we assume it's in there.
    Example:
    borrower = "\\NAS\traier\movie1-trailer.mov; \\NAS\traier\movie1-trailer-us.mov"

    b) How to play trailer:
    It could be done by using the exact same logic, that is used today in myfilms (starting player with a playlist) with one difference: content of playlist doesn't come from source, but from borrower instead. In consequence a new controlID is required: 102 as today is used for playing main movie, a new ID to be added to play the trailer playlist.

    c) Filteroption to only show records (=movies) with existing trailers for easier selection:
    This part is somehow "optional", but adds imho quite some valuadd to the user.

    In Mainscreen (MesFilms.xml), a new option should be added "show only movies with trailers". Could be done without skinchange by putting it as further entry in "options" menu.
    Default when initializing the plugin should always be false, setting it to true should be only temporary while using it. Reentering the plugin should also reset it to false.

    By this option, only records with trailers will be shown. For Implementation this means combining the search statement with a " ... AND myfilms.borrower NOT NULL".
    It requires a global variable to be set and using this variable as restriction in moviedisplay.
    Again, this mechanism already exists in the current code: It is almost exactly the same as AntFilterItem does (at least initially when loading a DB-config):

    <entry name="AntFilterItem1">borrower</entry>
    <entry name="AntFilterSign1">not like</entry>
    <entry name="AntFilterText1">''</entry>
    <entry name="AntFilterItem2">(none)</entry>
    <entry name="AntFilterSign2">#</entry>
    <entry name="AntFilterText2"></entry>
    <entry name="AntFilterComb">or</entry>

    So the easiest way of implementation could be, to add two options to enable or disable the already existing Antitemfilter1 and AntItemfilter2. This should be displayed with the localized label, so the skin would show "Toggle 'Trailer' " if <String id="10798656">Trailer </String> is set. Alternatively you could extend the AntFilterItem1 with "AntFilterName1" to get a proper label to display and let the user configure it).

    Since those changes do not require to be persistent, no update of myfilms.xml is necessary.

    As result, the user gets listings of only those movies, that have a trailer available and also the contextsensitive search ("search similar movies by properties" etc.) would work to search easily for movies that have trailers available.

    We could also export controlIDs, that do exactly what described (enabling/disabling AntFilter1 and AntFilter2) - so it would be easier to provide e.g. separate buttons for skinners - and maybe even exporting the status of the filter: #myfilms.status.AntItemFilter1=off for statusdisplay )

    Remark: The second available filter could be e.g. used to only display movies with rating above a defined value ... the only disadvatage would be: There would be no filter left to e.g. get rid of "rated movies" for kids...
    If there is userfeedback, that those filters are required, it should also not be too difficult, to add addtional "AntFilterItemX"s for theis purpose and keep the existing ones for usage as it is today.
    In this case I would suggest to add 3 more AntFilterItems as follows:
    1) Only movies with trailer (condition: borrower NOT NULL)
    2) Only movies available (condition: source NOT NULL)
    3) Only movies with rating above 'AntFilterItemY' > Value (While Value could be a variable to be set during runtime for this purpose).


    d) Search random movie (trailer) by property for improved workflow and userexperience:
    This is a bit "lastfm"-like ... and very simple function; Workflow as follows:
    In main screen's "Search" add a new item "Search random movie by property"
    Open dialog and let the user choose the property: "all", "category", "year", "country"
    Open next Dialog and present all items found in the chosen property (select distinct ....)
    Let the user choose the item
    Select a random movie of the resultlist
    Check if the movie has a trailer (myfilms.borrower NOT "")
    If yes, play the trailer (or ask the user, if he wants to launch the trailer)
    If a trailer was played, popup a dialog asking the user how to proceed:
    - "play main movie" (launch movie for 'selected record'),
    - "Show MovieDetails" (goes to MesFilmsDetails ID7987 with selected record to show DetailScreen)
    - "repeat random search in same category" (repeats a search in chosen propery and item),
    - "do another random search" (repeats a search from beginning again choosing property and items),
    - "go back" (back to main screen)


    This is in general a "movie-randomizer" - but with the setting from "c)" (only records with trailer present) you could randomly search for movies that all have trailers :)


    Ok, lot of text - I tried to point out possible solutions to make things easy...

    Actually I hope it's a lot of reusage of existing elements and thus reducing risk of breaking something else (and a good chance to get it done ....).

    Re AMCupdater stuff:
    As mentioned above, the scraping of trailers is a separate thing - and could be done by existing opensource applications (like mediamaster, ember media manager, MTS, etc.)
    It might be worth to think about letting AMCupdater to make the entrances in the source-field for the trailers (myfilms.borrower), but this is not related to myfilms directly.
    A very simple solution could be to let AMCupdater check on a certain location for filenames containing "moviename" and the word "trailer" and let it add them to the field ...

    Let me know, what you think.

    Guzzi

    PS: I know, that there are some changes required to mesfilms.dll and knowing that you focuse currently on bugfixing to release this version to all people waiting for it :) ... I checked sourceforge and found you posted updated code - so maybe I can do those changes by myself and provide you a "patch"-file (most stuff can be done with existing code, I think I should be able to do that ...).

    Edit because users feedback:

    This is NOT to delay current release of stable 5.0, if sourceforge issue are fixed I also could help fixing current issues for quick release of 5.0, that is the agreed focus :)

    -----------------------------------------------




    Hi Zebons,

    ok, I checked out the code from sourceforge, but unfortunately I was not able to compile it (Thus not able to make the changes required).

    So may I kindly ask you to fix the following things (problems I encountered):
    - Checkin of AMCupdater Code (Code is from 2009 and there is a reference in MyFilms to it)
    - add current grabber.dll to MyFilms directory so I can link it
    - Can you confirm, that Cornerstone.MP from 24/02/2010 is ok to compile?

    I made links to old grabber.dll, but think this might cause problems.

    Fehler 1 Der Typ- oder Namespacename "AntMovieCatalog" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?) H:\Daten\Entwicklung\MyFilms.GuzziMod\trunk\MyFilms\BaseMesFilms.cs 33 24 MesFilms
    Fehler 2 Der Typ- oder Namespacename "AntMovieCatalog" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?) H:\Daten\Entwicklung\MyFilms.GuzziMod\trunk\MyFilms\MesFilmsSetup.cs 51 17 MesFilms
    Fehler 3 "Action" ist ein mehrdeutiger Verweis und kann "System.Action" oder "MediaPortal.GUI.Library.Action" sein. H:\Daten\Entwicklung\MyFilms.GuzziMod\trunk\MyFilms\MesFilmsDetail.cs 149 39 MesFilms
    Fehler 4 "Action" ist ein mehrdeutiger Verweis und kann "System.Action" oder "MediaPortal.GUI.Library.Action" sein. H:\Daten\Entwicklung\MyFilms.GuzziMod\trunk\MyFilms\MesFilms.cs 218 39 MesFilms
    Fehler 5 Der Typ- oder Namespacename "AntMovieCatalog" konnte nicht gefunden werden. (Fehlt eine Using-Direktive oder ein Assemblyverweis?) H:\Daten\Entwicklung\MyFilms.GuzziMod\trunk\MyFilms\MesFilmsSetup.cs 1678 16 MesFilms

    You can verify the errors by checkin out the MyFilms in a new directory and try to compile it there...

    Thanks for your help,

    Guzzi
     

    z3us

    Portal Pro
    December 4, 2007
    1,047
    123
    46
    Home Country
    Spain Spain
    Guzzi please, no more features, we need a final version 5 :D
    Anyway the possibilities of improving the plugin are limited by AMC. If we really want new features we would need a new version of AMC with custom fields
     

    mattroby

    Portal Pro
    June 3, 2006
    73
    5
    Florida
    Home Country
    United States of America United States of America
    Guzzi please, no more features, we need a final version 5 :D
    Anyway the possibilities of improving the plugin are limited by AMC. If we really want new features we would need a new version of AMC with custom fields

    Agreed - at least no more features right now - maybe more later. I would love to see additional features like trailers and other enhancements. But they can all wait, in my opinion. I would rather get a good working v5.0 first, then come up with ideas for future releases.

    Zebons - Do you have a "google code" site to track issues? That way, ideas for future versions/bugs/enhancements can all be listed, sorted and prioritized. Just a thought.

    Looking forward to a final v5.0!

    Thanks for all of your hard work.
     

    ftothe3

    Portal Pro
    January 13, 2008
    178
    17
    Home Country
    United States of America United States of America
    hey zebons

    just finished the skinning for streamedmp but 2 issues remain

    1. pressing esc returns you to home not basichome (this worked in previous versions)

    2. i tried and tried but i cant get the options button to work.. can you look at the xml? maybe theres a problem with using id 5?

    thanks

    p.s. a feature freeze sounds like a good idea


    edit- those that want the complete streamedmp xmls can find them here
    https://forum.team-mediaportal.com/606544-post574.html

    edit2: fixed default bg
     

    Attachments

    • MesFilms.xml
      30.6 KB
    • MesFilms.common.facade.xml
      30.7 KB
    Status
    Not open for further replies.

    Users who are viewing this thread

    Similar threads

    It may seem strange, but the open-source license allows anyone to sell physical CDs or DVDs to customers, provided that, for example, the source code is made available upon request and additional value is provided, such as an installation manual. Both of these are mentioned in the product description, so it appears to be legitimate...
    It may seem strange, but the open-source license allows anyone to sell physical CDs or DVDs to customers, provided that, for...
    I just recently started using your software and I noticed on eBay one person is selling it for about $16.00. You can make a claim...
    Replies
    2
    Views
    152
    Fixed, I think. Certainly the vintage MP2 installer that I was using no longer installs the LAV filters. I can only assume that these were never part of the install package itself, but rather downloaded during the install, and that link no longer exists. Shame that the installer doesn't indicate this. Last time when I installed the...
    Fixed, I think. Certainly the vintage MP2 installer that I was using no longer installs the LAV filters. I can only assume that...
    Hi all, I've recently retired my MP2 setup for my main HTPC and gone back to separates, but I wanted to retain the ability to play...
    Replies
    4
    Views
    212
    If you’re planning to submit a pull request, let’s go through the list of issues and their solutions. I or someone from the team will create a Jira ticket, and for each ticket, you’ll make the changes and submit a pull request. This will be transparent and straightforward.
    If you’re planning to submit a pull request, let’s go through the list of issues and their solutions. I or someone from the team...
    I'm very glad to see that mediaportal 1 is on github, where ordinary devs with github accounts can make contributions. Please can...
    Replies
    7
    Views
    1K
    Thank you for this tip! I'm moving MP TV Server to a new machine. I installed the 64-bit version and most of the MP firewall rules were set to Public. I couldn't connect to the new TV Server from my old single-seat installation running 32-bit until I changed all MP-related firewall rules on the new machine to Private. Before I did...
    Thank you for this tip! I'm moving MP TV Server to a new machine. I installed the 64-bit version and most of the MP firewall...
    Server and client on modern uptodate Windows 11 desktop. Software is Server and Client version x86 1.38.003 Remote client on...
    Replies
    26
    Views
    3K
    TV Server plugins are listed on this page, and "EPG Cleaner" can be downloaded from this page. Note: I don't know what bitness the plugin has. It might be 32-bit, or it might be "any cpu". The plugin is not listed by the "MP Extensions" tool, so I don't know whether it has been tested with the most-recent MP releases. -- from...
    TV Server plugins are listed on this page, and "EPG Cleaner" can be downloaded from this page. Note: I don't know what bitness the...
    I'm looking for a better recording scheduler. Many recording titles (at least in the UK) change between episodes, sometimes being...
    Replies
    4
    Views
    1K
    Top Bottom