[MP1-4742] Rework keepstartfullscreen option to be able to switch to windowed mode

Discussion in 'General Support' started by mm1352000, January 1, 2016.

  1. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,541
    Likes Received:
    4,752
    Ratings:
    +8,221 / 17
    Home Country:
    New Zealand New Zealand
    @Sebastiii
    Why does windowed mode need to be blocked?


     
    • Like Like x 2
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. regeszter
    • Premium Supporter

    regeszter Retired Team Member

    Joined:
    October 29, 2005
    Messages:
    5,335
    Likes Received:
    2,863
    Ratings:
    +5,152 / 18
    Home Country:
    Hungary Hungary
    Good question.
     
    • Funny Funny x 1
  4. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,317
    Likes Received:
    6,258
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,296 / 9
    Home Country:
    France France
    Show System Specs
  5. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,541
    Likes Received:
    4,752
    Ratings:
    +8,221 / 17
    Home Country:
    New Zealand New Zealand
    Sure, but wouldn't it be easy for the code to "override"/ignore the messages only in fullscreen mode [and not override/ignore the messages in windowed mode]?

    Remove the "if" here:
    https://github.com/MediaPortal/Medi.../MediaPortal.Application/MediaPortal.cs#L4027

    Change this back to "Windowed = !startFullscreen;":
    https://github.com/MediaPortal/Medi...Portal.Application/MediaPortal.cs#L1263-L1270

    ...and finally, replace all of:
    Code (Text):
    1. if (!_keepstartfullscreen) ...
    ...with...
    Code (Text):
    1. if (Windowed || !_keepstartfullscreen) ...
    The wording can easily be modified.

    Is there some other reason - technical, usability etc. - to need or want to disable windowed mode?

    Reason I ask this question: currently there seems to be no easy solution for somebody who wants to force MP to stay fullscreen in fullscreen mode... but sometimes also wants to use windowed mode.
     
    • Like Like x 1
  6. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,317
    Likes Received:
    6,258
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,296 / 9
    Home Country:
    France France
    Show System Specs
    Hi @mm1352000

    It's really to avoid MP resolution to change (can be useful on resume etc.)
    When we authorize 'togglefullscreen' we need to authorize all other code like :
    WM_GETMINMAXINFO
    WM_SIZE
    WM_SIZING
    etc.
    And when resume with the 1024x768 issue, it can failed for some people, this is why such option was corrected to not permit it if we want MP to stay Fullscreen.

    So you are right that if "override"/ignore the messages only in fullscreen mode [and not override/ignore the messages in windowed mode] could do the trick too, like this if we are in fullscreen it will stay like this :) (I like the idea)

    What wording can we change for that option ?

    Also i think we should remove the 'if (!_keepstartfullscreen) ... here : (right ?)
    https://github.com/MediaPortal/Medi...diaportal/MediaPortal.Application/D3D.cs#L487

    Thanks :)
     
    • Agree Agree x 1
  7. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,541
    Likes Received:
    4,752
    Ratings:
    +8,221 / 17
    Home Country:
    New Zealand New Zealand
    Yes, that's right - sorry I missed that the setting was also used in D3D. :oops:

    Maybe something like: "Ignore Windows resolution/size changes in fullscreen mode".

    Note I took out the reference to "start"/"startup" because:
    • when starting in fullscreen mode, MP resolution would be taken from the current screen resolution
    • when starting in windowed mode and/or later toggling from windowed to fullscreen mode, MP resolution would be taken from the current screen resolution (not the screen resolution at startup, even if starting in fullscreen mode)
    To be clear: I think the second point/behaviour is desirable. This enables people to use window/fullscreen mode toggle to reset MP's size/resolution (in case of error).

    P.S. I would also change the variable (and setting???) name in the code from _keepstartfullscreen to something like _ignoreFullscreenResolutionChanges to be consistent.
     
    • Like Like x 1
  8. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,317
    Likes Received:
    6,258
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,296 / 9
    Home Country:
    France France
    Show System Specs
  9. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,541
    Likes Received:
    4,752
    Ratings:
    +8,221 / 17
    Home Country:
    New Zealand New Zealand
    • Thank You! Thank You! x 1
    • Add to Wiki! Add to Wiki! x 1
  10. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,317
    Likes Received:
    6,258
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,296 / 9
    Home Country:
    France France
    Show System Specs
    • Thank You! Thank You! x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!