Athena Skin Missing Screenshots (1 Viewer)

[SpudR]

Pressing the 'Screenshot' button on the MPEI > Known Extensions > Athena shows an image placeholder, then crashes the MPEI totally, if you step through the 5.

 

[SpudR]

No reply?

 

[SpudR]

Replies: 1
Views:188
WOW
No-one??

 

[JimCatMP]

Not much to say other than 'confirmed'

Testing a few other, many missing images [Xtreme - 32 listed, none present, only Athena seems to crash MPEI on ones I tested [5 or 6].

TTFN - JCMP

 

[SpudR]

Thanks for the confirmation - now we just need as @Developers to take a look

 

[Edalex]

I've looked at Athena MPEI.
You saw placeholders instead of images because links are 404

<SectionParam Name="Online Screenshots">
<Value>
http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2304.jpg; http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2307.jpg; http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2306.jpg; http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2305.jpg;
</Value>
<ValueType>String</ValueType>
<Description>Online stored screenshot urls separated by ;</Description>
</SectionParam>

Current images on site look like this https://www.team-mediaportal.com/media/com_mtree/images/listings/o/2307.jpg
So probably site changed a bit.
I can't say for sure about crash but looks like MPEI thinks thre are 5 pictures. Obviously, because of additional ; after the text.
I didn't find the code executing Screenshot loading by github search and I'm lazy to debug MPEI so you could believe in my vesion or wait another one.
Nah, I found it MediaPortal-1/ScreenShotNavigator.cs at ff4edb5f3612e397136971c4a3a57a2aa2ffcfc8 · MediaPortal/MediaPortal-1 · GitHub
No checks if urls are valid there.
And yes, such exceptions should be handled properly to avoid crashes and yes, MPEI should have log.
Br.

 

[Edalex]

@high maybe you could lokk at this issue too.
Site changes produced dead links

 

[high]

image-links changed ~ 2 years ago. I can create a rewrite for these old ones but still, there will be missing images cause author deleted/exchanged them. In athena for example 2304.jpg.

false urls need to be covered in MPEI-code properly. I can fix local xml files like in the Athena-case but not external hosted ones (github/Google Code)

 

[high]

Athena is fixed, the issue should not show up again for this item .
Also rewrite old images to 'new' location to fix old ones like Xtreme

 

[Edalex]

not that much I can do, image-links changed ~ 2 years ago. I can create a rewrite for these old ones but still, there will be missing images cause author deleted/exchanged them. In athena for example 2304.jpg.

This needs to be fixed in MPEI-code properly.

What about redirection from old path to new? Not sure Mpei will handle redirect properly though
Upd. Ooops, I didn't read your second message