Athena Skin Missing Screenshots

Discussion in 'Skins and Plugins Installer (MPEI)' started by SpudR, May 18, 2017.

  1. SpudR
    • Team MediaPortal

    SpudR Documentation Group

    Joined:
    July 27, 2007
    Messages:
    2,565
    Likes Received:
    446
    Occupation:
    CTO, MD
    Location:
    Yorkshire, UK
    Ratings:
    +669 / 2
    Home Country:
    England England
    Show System Specs
    Pressing the 'Screenshot' button on the MPEI > Known Extensions > Athena shows an image placeholder, then crashes the MPEI totally, if you step through the 5.


     
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. SpudR
    • Team MediaPortal

    SpudR Documentation Group

    Joined:
    July 27, 2007
    Messages:
    2,565
    Likes Received:
    446
    Occupation:
    CTO, MD
    Location:
    Yorkshire, UK
    Ratings:
    +669 / 2
    Home Country:
    England England
    Show System Specs
    No reply?
     
  4. SpudR
    • Team MediaPortal

    SpudR Documentation Group

    Joined:
    July 27, 2007
    Messages:
    2,565
    Likes Received:
    446
    Occupation:
    CTO, MD
    Location:
    Yorkshire, UK
    Ratings:
    +669 / 2
    Home Country:
    England England
    Show System Specs
    Replies: 1
    Views:188
    WOW
    No-one??
     
  5. JimCatMP
    • Team MediaPortal

    JimCatMP Documentation Group

    Joined:
    April 1, 2010
    Messages:
    646
    Likes Received:
    152
    Gender:
    Male
    Location:
    Leeds
    Ratings:
    +281 / 1
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Not much to say other than 'confirmed' :oops:

    Testing a few other, many missing images [Xtreme - 32 listed, none present:rolleyes:, only Athena seems to crash MPEI on ones I tested [5 or 6].

    TTFN - JCMP
     
  6. SpudR
    • Team MediaPortal

    SpudR Documentation Group

    Joined:
    July 27, 2007
    Messages:
    2,565
    Likes Received:
    446
    Occupation:
    CTO, MD
    Location:
    Yorkshire, UK
    Ratings:
    +669 / 2
    Home Country:
    England England
    Show System Specs
    Thanks for the confirmation - now we just need as @Developers to take a look :)
     
    • Agree Agree x 1
  7. Edalex
    • Premium Supporter

    Edalex Community Plugin Dev

    Joined:
    January 3, 2008
    Messages:
    2,897
    Likes Received:
    708
    Gender:
    Male
    Location:
    Saratov
    Ratings:
    +1,222 / 9
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    I've looked at Athena MPEI.
    You saw placeholders instead of images because links are 404
    Code (XML):
    1. <SectionParam Name="Online Screenshots">
    2. <Value>
    3. http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2304.jpg; http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2307.jpg; http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2306.jpg; http://www.team-mediaportal.com/components/com_mtree/img/listings/m/2305.jpg;
    4. </Value>
    5. <ValueType>String</ValueType>
    6. <Description>Online stored screenshot urls separated by ;</Description>
    7. </SectionParam>
    Current images on site look like this https://www.team-mediaportal.com/media/com_mtree/images/listings/o/2307.jpg
    So probably site changed a bit.
    I can't say for sure about crash but looks like MPEI thinks thre are 5 pictures. Obviously, because of additional ; after the text.
    I didn't find the code executing Screenshot loading by github search and I'm lazy to debug MPEI so you could believe in my vesion or wait another one. ;)
    Nah, I found it MediaPortal-1/ScreenShotNavigator.cs at ff4edb5f3612e397136971c4a3a57a2aa2ffcfc8 · MediaPortal/MediaPortal-1 · GitHub
    No checks if urls are valid there.
    And yes, such exceptions should be handled properly to avoid crashes and yes, MPEI should have log.
    Br.
     
    Last edited: May 30, 2017
    • Thank You! Thank You! x 1
    • Informative Informative x 1
  8. Edalex
    • Premium Supporter

    Edalex Community Plugin Dev

    Joined:
    January 3, 2008
    Messages:
    2,897
    Likes Received:
    708
    Gender:
    Male
    Location:
    Saratov
    Ratings:
    +1,222 / 9
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    @high maybe you could lokk at this issue too.
    Site changes produced dead links :whistle:
     
  9. high
    • Team MediaPortal
    • IT-Admin

    high Administrator

    Joined:
    August 31, 2004
    Messages:
    4,721
    Likes Received:
    3,077
    Gender:
    Male
    Occupation:
    Sysadmin
    Location:
    Isselburg/NRW
    Ratings:
    +4,783 / 6
    Home Country:
    Germany Germany
    Show System Specs
    image-links changed ~ 2 years ago. I can create a rewrite for these old ones but still, there will be missing images cause author deleted/exchanged them. In athena for example 2304.jpg.

    false urls need to be covered in MPEI-code properly. I can fix local xml files like in the Athena-case but not external hosted ones (github/Google Code)
     
    Last edited: July 1, 2017
  10. high
    • Team MediaPortal
    • IT-Admin

    high Administrator

    Joined:
    August 31, 2004
    Messages:
    4,721
    Likes Received:
    3,077
    Gender:
    Male
    Occupation:
    Sysadmin
    Location:
    Isselburg/NRW
    Ratings:
    +4,783 / 6
    Home Country:
    Germany Germany
    Show System Specs
    Athena is fixed, the issue should not show up again for this item .
    Also rewrite old images to 'new' location to fix old ones like Xtreme
     
  11. Edalex
    • Premium Supporter

    Edalex Community Plugin Dev

    Joined:
    January 3, 2008
    Messages:
    2,897
    Likes Received:
    708
    Gender:
    Male
    Location:
    Saratov
    Ratings:
    +1,222 / 9
    Home Country:
    Russian Federation Russian Federation
    Show System Specs
    What about redirection from old path to new? Not sure Mpei will handle redirect properly though :cautious:
    Upd. Ooops, I didn't read your second message :D
     
    • Like Like x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!